You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/06/19 22:32:32 UTC
[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it
Hello Henry Robinson, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10761
to review the following change.
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
......................................................................
Propagate HAVE_PIPE2 compile time value to files that use it
The HAVE_PIPE2 is a variable that tracks whether a platform has the
system function pipe2() present.
This value was not propagated to the appropriate file that uses it,
causing its value to always be 0, and the wrong branch to be taken
at compile time.
This fixes it by propagating the value to the file.
Change-Id: I72069f32d98e1ba9a2b475344dd5d30f5884464d
Reviewed-on: http://gerrit.cloudera.org:8080/7705
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/util/subprocess.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/10761/1
--
To view, visit http://gerrit.cloudera.org:8080/10761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72069f32d98e1ba9a2b475344dd5d30f5884464d
Gerrit-Change-Number: 10761
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Propagate HAVE PIPE2 compile time value to files that use it
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/10761 )
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
......................................................................
Abandoned
Not needed anymore.
--
To view, visit http://gerrit.cloudera.org:8080/10761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I72069f32d98e1ba9a2b475344dd5d30f5884464d
Gerrit-Change-Number: 10761
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>