[GitHub] [echarts] Ovilia commented on a change in pull request #16206: fix: Axis.nameTextStyle.width is not valid

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #16206:
URL: https://github.com/apache/echarts/pull/16206#discussion_r776128204



##########
File path: src/component/axis/AxisBuilder.ts
##########
@@ -435,7 +435,7 @@ const builders: Record<'axisLine' | 'axisTickLabel' | 'axisName', AxisElementsBu
                 text: name,
                 font: textFont,
                 overflow: 'truncate',
-                width: maxWidth,
+                width: maxWidth || +textStyleModel.get('width') || undefined,

Review comment:
       What if a user set the width to be 0? Is this valid? (It seems to be valid to me.) If it is valid, would `|| undefined` make it be `undefined` instead of 0? Is this intended or what does `|| undefined` do?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org