You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/03/09 21:40:00 UTC
[jira] [Updated] (CALCITE-5571) Remove org.jetbrains.annotations from java source code
[ https://issues.apache.org/jira/browse/CALCITE-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated CALCITE-5571:
------------------------------------
Labels: pull-request-available (was: )
> Remove org.jetbrains.annotations from java source code
> ------------------------------------------------------
>
> Key: CALCITE-5571
> URL: https://issues.apache.org/jira/browse/CALCITE-5571
> Project: Calcite
> Issue Type: Task
> Affects Versions: 1.33.0
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the most part we are using checkerframework annotations (org.checkerframework.checker.nullness.qual) for specifying nullability. There are 2 places, namely {{ScannableTableTest}} and {{UtilTest}} where we have nullability annotations from org.jetbrains.annotations package.
> To keep things consistent and also avoid mixing up annotations from different providers in the future, I propose to remove the last references to org.jetbrains.annotations and exclude the org.jetbrains:annotations dependency from the build to avoid accidentally using such annotations in the future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)