[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #69: HDDS-2343. Add immutable entries in to the DoubleBuffer for Bucket requests.

[GitBox <gi...@apache.org>]

bharatviswa504 opened a new pull request #69: HDDS-2343. Add immutable entries in to the DoubleBuffer for Bucket requests.
URL: https://github.com/apache/hadoop-ozone/pull/69
 
 
   
   =## What changes were proposed in this pull request?
   
   ```
   OMBucketCreateRequest.java L181:
   
   omClientResponse =
   new OMBucketCreateResponse(omBucketInfo,
   omResponse.build());
   ```
   
    
   We add this to double-buffer, and double-buffer flushThread which is running in the background when picks up, converts to protoBuf and to ByteArray and write to rocksDB tables. So, during this conversion(This conversion will be done without any lock acquire), if any other request changes internal structure(like acls list) of OMBucketInfo we might get ConcurrentModificationException.
   
   In this Jira handled Bucket requests, when adding entries to doubleBuffer cloned them and added to it. 
   
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-2343
   
   ## How was this patch tested?
   
   Ran TestOzoneRpcClient which tests this code path.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org