You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "timtebeek (via GitHub)" <gi...@apache.org> on 2023/05/10 11:29:22 UTC
[GitHub] [maven-wagon] timtebeek opened a new pull request, #90: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
timtebeek opened a new pull request, #90:
URL: https://github.com/apache/maven-wagon/pull/90
Continuation of https://issues.apache.org/jira/browse/MNG-6829
Review requested of @elharo
Use this link to re-run the recipe: https://public.moderne.io/recipes/org.openrewrite.java.migrate.apache.commons.lang.IsNotEmptyToJdk?organizationId=QXBhY2hlIE1hdmVu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wagon] elharo commented on a diff in pull request #90: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #90:
URL: https://github.com/apache/maven-wagon/pull/90#discussion_r1189840399
##########
wagon-provider-test/src/main/java/org/apache/maven/wagon/http/HttpWagonTestCase.java:
##########
@@ -936,7 +936,7 @@ protected void checkHandlerResult( List<HandlerRequestResponse> handlerRequestRe
{
for ( int i = 0; i < expectedResponseCodes.length; i++ )
{
- success &= ( expectedResponseCodes[i] == handlerRequestResponses.get( i ).responseCode );
+ success &= expectedResponseCodes[i] == handlerRequestResponses.get( i ).responseCode;
Review Comment:
This change isn't wrong, but doesn't seem related to isEmpty methods. What's happening?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wagon] slachiewicz merged pull request #90: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #90:
URL: https://github.com/apache/maven-wagon/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wagon] timtebeek commented on pull request #90: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #90:
URL: https://github.com/apache/maven-wagon/pull/90#issuecomment-1542883798
The checkstyle violations would need a manual fix; could pick this up again later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wagon] timtebeek commented on a diff in pull request #90: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on code in PR #90:
URL: https://github.com/apache/maven-wagon/pull/90#discussion_r1189909018
##########
wagon-provider-test/src/main/java/org/apache/maven/wagon/http/HttpWagonTestCase.java:
##########
@@ -936,7 +936,7 @@ protected void checkHandlerResult( List<HandlerRequestResponse> handlerRequestRe
{
for ( int i = 0; i < expectedResponseCodes.length; i++ )
{
- success &= ( expectedResponseCodes[i] == handlerRequestResponses.get( i ).responseCode );
+ success &= expectedResponseCodes[i] == handlerRequestResponses.get( i ).responseCode;
Review Comment:
As an implementation detail, the recipe to remove StringUtils isEmpty originally insta the statement wrapped in parentheses. Then, only when possible, it [removes unnecessary parentheses](https://github.com/openrewrite/rewrite-migrate-java/blob/main/src/main/java/org/openrewrite/java/migrate/apache/commons/lang/IsNotEmptyToJdk.java#L94). In rare cases that might clean up unrelated parentheses. Should be rare, but I thought it to be mostly harmless. Let me know if you'd like me to prevent such changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wagon] elharo commented on pull request #90: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #90:
URL: https://github.com/apache/maven-wagon/pull/90#issuecomment-1547663833
CI might be borken:
Error: Tests run: 69, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 31.818 s <<< FAILURE! - in org.apache.maven.wagon.providers.webdav.WebDavsWagonPreemptiveTest
Error: testWagonGetIfNewerIsNewer(org.apache.maven.wagon.providers.webdav.WebDavsWagonPreemptiveTest) Time elapsed: 0.047 s <<< ERROR!
java.io.IOException: File D:\a\maven-wagon\maven-wagon\wagon-providers\wagon-webdav-jackrabbit\target\test-output\http-repository\newfolder\folder2\a\b\test-resource-3.txt unable to be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org