You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2013/02/01 17:22:58 UTC
git commit: TS-1252: stats summary in cluster not working
Updated Branches:
refs/heads/master 75a7e7b4e -> baca4d2b7
TS-1252: stats summary in cluster not working
Here is some stats with evil result, we all know that most stats
with proxy.process.cluster prefix have no result at all.
proxy.process.cluster.open_delays=-4411607530454032024
proxy.process.cluster.control_messages_avg_send_time=-72.902885
proxy.process.cluster.open_delay_time=-2494.564697
proxy.process.cluster.rmt_cache_callback_time=-747.036865
proxy.process.cluster.local_connection_time=-15.002351
When int64_t integer was passed to CLUSTER_SUM_DYN_STAT(x, y) as
2th parameter, it would be convert to int unsafely.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/baca4d2b
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/baca4d2b
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/baca4d2b
Branch: refs/heads/master
Commit: baca4d2b702b7d2df99ec582185560ad80acd2ce
Parents: 75a7e7b
Author: Yunkai Zhang <qi...@taobao.com>
Authored: Fri Feb 1 08:22:39 2013 -0800
Committer: James Peach <jp...@apache.org>
Committed: Fri Feb 1 08:22:39 2013 -0800
----------------------------------------------------------------------
CHANGES | 3 +++
iocore/cluster/P_Cluster.h | 2 +-
proxy/logging/LogConfig.h | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/baca4d2b/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index da25b69..ad32f87 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
-*- coding: utf-8 -*-
Changes with Apache Traffic Server 3.3.1
+ *) [TS-1252] stats summary in cluster not working
+ Author: Yunkai Zhang <qi...@taobao.com>
+
*) [TS-1679] channel_stats plugin: count 5xx response and clean up code
Author: Conan Wang
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/baca4d2b/iocore/cluster/P_Cluster.h
----------------------------------------------------------------------
diff --git a/iocore/cluster/P_Cluster.h b/iocore/cluster/P_Cluster.h
index 7c42a95..47865ed 100644
--- a/iocore/cluster/P_Cluster.h
+++ b/iocore/cluster/P_Cluster.h
@@ -131,7 +131,7 @@ extern RecRawStatBlock *cluster_rsb;
#define CLUSTER_DECREMENT_DYN_STAT(x) \
RecIncrRawStat(cluster_rsb, mutex->thread_holding, (int) x, -1);
#define CLUSTER_SUM_DYN_STAT(x, y) \
- RecIncrRawStat(cluster_rsb, mutex->thread_holding, (int) x, (int) y);
+ RecIncrRawStat(cluster_rsb, mutex->thread_holding, (int) x, y);
#define CLUSTER_SUM_GLOBAL_DYN_STAT(x, y) \
RecIncrGlobalRawStatSum(cluster_rsb,x,y)
#define CLUSTER_CLEAR_DYN_STAT(x) \
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/baca4d2b/proxy/logging/LogConfig.h
----------------------------------------------------------------------
diff --git a/proxy/logging/LogConfig.h b/proxy/logging/LogConfig.h
index b90dc12..7430d40 100644
--- a/proxy/logging/LogConfig.h
+++ b/proxy/logging/LogConfig.h
@@ -64,7 +64,7 @@ do { \
#define LOG_DECREMENT_DYN_STAT(x) \
RecIncrRawStat(log_rsb, mutex->thread_holding, (int) x, -1);
#define LOG_SUM_DYN_STAT(x, y) \
- RecIncrRawStat(log_rsb, mutex->thread_holding, (int) x, (int) y);
+ RecIncrRawStat(log_rsb, mutex->thread_holding, (int) x, y);
#define LOG_SUM_GLOBAL_DYN_STAT(x, y) \
RecIncrGlobalRawStatSum(log_rsb,x,y)
#define LOG_CLEAR_DYN_STAT(x) \