You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/04/29 10:33:53 UTC
[GitHub] [calcite] danny0405 commented on a change in pull request #1188:
[CALCITE-3034] CSV test case description does not match it's code logic
danny0405 commented on a change in pull request #1188: [CALCITE-3034] CSV test case description does not match it's code logic
URL: https://github.com/apache/calcite/pull/1188#discussion_r279311370
##########
File path: example/csv/src/main/java/org/apache/calcite/adapter/csv/CsvFilterableTable.java
##########
@@ -63,7 +63,11 @@ public String toString() {
}
private boolean addFilter(RexNode filter, Object[] filterValues) {
- if (filter.isA(SqlKind.EQUALS)) {
+ if (filter.isA(SqlKind.AND)) {
Review comment:
What about the predicate `OR`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services