You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/11 22:01:56 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #17562: Chart: Support extraContainers in k8s workers
jedcunningham opened a new pull request #17562:
URL: https://github.com/apache/airflow/pull/17562
This allows extraContainers to be provided for k8s workers, however one
must keep in mind they are responsible for signaling any sidecars to
exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17562: Chart: Support extraContainers in k8s workers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17562:
URL: https://github.com/apache/airflow/pull/17562#issuecomment-897207982
OH NO.. I see that Sidecar container feature has not only dropped from 1.18, but also did not make it to 1.19 and 1.20 and has been finally dropped (https://github.com/kubernetes/enhancements/issues/753) what a PITY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #17562: Chart: Support extraContainers in k8s workers
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17562:
URL: https://github.com/apache/airflow/pull/17562#issuecomment-897197886
Should not we use (and possibly even enforce) the "lifecycle: Sidecar" for those extraContainers ? It is available from K8S 1.18 and seems to handle nicely not only automated termination when all "Standard" containers finished but also proper sequence of Pod termination:
https://banzaicloud.com/blog/k8s-sidecars/#example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17562: Chart: Support extraContainers in k8s workers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17562:
URL: https://github.com/apache/airflow/pull/17562#issuecomment-897197886
Should not we use (and possibly even enforce) the "lifecycle: Sidecar" ? It is available from K8S 1.18 and seems to handle nicely not only automated termination when all "Standard" containers finished but also proper sequence of Pod termination:
https://banzaicloud.com/blog/k8s-sidecars/#example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17562: Chart: Support extraContainers in k8s workers
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17562:
URL: https://github.com/apache/airflow/pull/17562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17562: Chart: Support extraContainers in k8s workers
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17562:
URL: https://github.com/apache/airflow/pull/17562#issuecomment-897191987
I'm tempted to also add a warning in `NOTES.txt` (maybe with a way to hide the warning so folks aren't annoyed). Thoughts?
(I just foresee folks running into issues with this even with the notes I'm already adding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17562: Chart: Support extraContainers in k8s workers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17562:
URL: https://github.com/apache/airflow/pull/17562#issuecomment-897194550
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org