You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by "ramanathan1504 (via GitHub)" <gi...@apache.org> on 2026/07/16 07:21:17 UTC

Re: [PR] [main] Add `@Required` and validation to `StringMatchFilter` `text` attribute (#3158 port) [logging-log4j2]

ramanathan1504 commented on PR #4153:
URL: https://github.com/apache/logging-log4j2/pull/4153#issuecomment-4989243898

   @vpelikh 
   
   It turns out the original author (@JWT007) already started porting this to main over in PR #3510, but that PR stalled and still has some unresolved review comments from @vy and @ppkarwasz .
   
   Since he already did half the work, could you pull his commits into this PR (to preserve his authorship), and then address the review feedback that @vy  and @ppkarwasz  left on #3510?
   
   If you can resolve those review comments here in this PR, I will close the old PR and we can focus on getting yours reviewed and merged!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org