You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/09 15:15:09 UTC
[GitHub] [arrow] pitrou commented on a change in pull request #8516: PARQUET-1935: [C++] Fix bug in WriteBatchSpaced
pitrou commented on a change in pull request #8516:
URL: https://github.com/apache/arrow/pull/8516#discussion_r519886116
##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1190,7 +1192,7 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<
int64_t* out_spaced_values_to_write,
int64_t* null_count) {
if (bits_buffer_ == nullptr) {
- if (!level_info_.HasNullableValues()) {
+ if (level_info_.def_level == 0) {
Review comment:
Interesting. Why is a special case needed for this? Would you like to add a comment?
##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1190,7 +1192,7 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<
int64_t* out_spaced_values_to_write,
int64_t* null_count) {
if (bits_buffer_ == nullptr) {
- if (!level_info_.HasNullableValues()) {
+ if (level_info_.def_level == 0) {
Review comment:
Do you also want to check `def_levels` for null/non-null-ness? (debug mode check perhaps?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org