You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by GitRubb <gi...@git.apache.org> on 2016/04/07 20:11:04 UTC
[GitHub] cordova-android pull request: CB-8383 Handle pause event when keep...
GitHub user GitRubb opened a pull request:
https://github.com/apache/cordova-android/pull/288
CB-8383 Handle pause event when keeprunning=false
I added this pull request to hopefully get some attention to this bug https://issues.apache.org/jira/browse/CB-8383. When keeprunning = false in config.xml, any pause event processing is halted until the app returns. Not only is the pause event missed on app backgrounding, but on return it processes the pause and resume events.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GitRubb/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit 101ac992a1bac00863177bba42735389dbef3206
Author: GitRubb <er...@gmail.com>
Date: 2016-04-07T18:09:30Z
CB-8383 Handle pause event when keeprunning=false
I added this pull request to hopefully get some attention to this bug https://issues.apache.org/jira/browse/CB-8383. When keeprunning = false in config.xml, any pause event processing is halted until the app returns. Not only is the pause event missed on app backgrounding, but on return it processes the pause and resume events.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #288: CB-8383 Handle pause event when keeprunning=fals...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/288
Closing pull request due to it disabling pause/resume behaviour.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-8383 Handle pause event when keep...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/288#issuecomment-209673913
This does not work, since all actions on a WebView thread MUST happen on the UI thread. Also, you don't actually start the thread at all and this patch breaks the pause/resume functionality of KeepRunning entirely.
Adding a thread just for the sake of adding a thread is generally a bad idea, especially when you have to pause something that runs on the UI thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #288: CB-8383 Handle pause event when keeprunni...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #288: CB-8383 Handle pause event when keeprunning=fals...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/288
## [Current coverage][cc-pull] is **33.29%**
> Merging [#288][cc-pull] into [master][cc-base-branch] will decrease coverage by **2.99%**
```diff
@@ master #288 diff @@
=====================================
Files 11 11
Lines 926 916 -10
Methods 0 0
Branches 167 167
=====================================
- Hits 336 305 -31
- Misses 590 610 +20
- Partials 0 1 +1
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [9af7f50...98d1460][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-android/compare/9af7f506f03b468734406341ae98599dbd2af676...98d1460f808073dc94ad2cd1fa989156a7d8f91d
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/288?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org