You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <ht...@schubergphilis.com> on 2012/07/06 13:50:23 UTC
Review Request: cloud-vmware.jar needs to be in the system vm for the
PremiumSecondaryStorageResource to work
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5804/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
PremiumSecondaryStorageResource depends on VmwareSecondaryStorageContextFactory and VmwareSecondaryStorageResourceHandler, which were move to cloud-vmware.jar
Diffs
-----
build/build-cloud.xml b8ad09e
build/package.xml 2b5a74b
Diff: https://reviews.apache.org/r/5804/diff/
Testing
-------
Create new zone
Download template after ssvm has booted
Thanks,
Hugo Trippaers
RE: Review Request: cloud-vmware.jar needs to be in the system vm
for the PremiumSecondaryStorageResource to work
Posted by Edison Su <Ed...@citrix.com>.
I added a temporary fix in commit, 27e9cdbece932bae9a68d5ec28bf2941f4fc7545, to use com.cloud.storage.resource.NfsSecondaryStorageResource, instead of PremiumSecondaryStorageResource.
Unless we figure it out how to build/package VMware, we can leave it there.
From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
Sent: Tuesday, July 24, 2012 4:24 PM
To: Edison Su
Cc: cloudstack; Edison Su
Subject: Re: Review Request: cloud-vmware.jar needs to be in the system vm for the PremiumSecondaryStorageResource to work
Hey disheng,
Good point, however current it means that the secondary storage vm will not work as the default (premium) configuration will tell the secstorage vm to use the premium storage class which depends on VMware.
A work around could be to attempt to load the VMware class by code and on class load exception load the regular Nfs secstorage class.
Cheers,
Hugo
Sent from my iPhone
On 24 jul. 2012, at 23:05, "disheng su" <ed...@citrix.com>> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5804/
the agent package depends on vmware, if vmware hypervisor is used. We can't just add PremiumSecondaryStorageResource back into core, as it depends on vmware library, thus may break the apache license.
As we already build vmware separately, need a way to add vmware related jar files into agent.tgz, such as "ant package-agent-with-vmware"
- disheng
On July 6th, 2012, 11:50 a.m., Hugo Trippaers wrote:
Review request for cloudstack.
By Hugo Trippaers.
Updated July 6, 2012, 11:50 a.m.
Description
PremiumSecondaryStorageResource depends on VmwareSecondaryStorageContextFactory and VmwareSecondaryStorageResourceHandler, which were move to cloud-vmware.jar
Testing
Create new zone
Download template after ssvm has booted
Diffs
* build/build-cloud.xml (b8ad09e)
* build/package.xml (2b5a74b)
View Diff<https://reviews.apache.org/r/5804/diff/>
Re: Review Request: cloud-vmware.jar needs to be in the system vm
for the PremiumSecondaryStorageResource to work
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Hey disheng,
Good point, however current it means that the secondary storage vm will not work as the default (premium) configuration will tell the secstorage vm to use the premium storage class which depends on VMware.
A work around could be to attempt to load the VMware class by code and on class load exception load the regular Nfs secstorage class.
Cheers,
Hugo
Sent from my iPhone
On 24 jul. 2012, at 23:05, "disheng su" <ed...@citrix.com>> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5804/
the agent package depends on vmware, if vmware hypervisor is used. We can't just add PremiumSecondaryStorageResource back into core, as it depends on vmware library, thus may break the apache license.
As we already build vmware separately, need a way to add vmware related jar files into agent.tgz, such as "ant package-agent-with-vmware"
- disheng
On July 6th, 2012, 11:50 a.m., Hugo Trippaers wrote:
Review request for cloudstack.
By Hugo Trippaers.
Updated July 6, 2012, 11:50 a.m.
Description
PremiumSecondaryStorageResource depends on VmwareSecondaryStorageContextFactory and VmwareSecondaryStorageResourceHandler, which were move to cloud-vmware.jar
Testing
Create new zone
Download template after ssvm has booted
Diffs
* build/build-cloud.xml (b8ad09e)
* build/package.xml (2b5a74b)
View Diff<https://reviews.apache.org/r/5804/diff/>
Re: Review Request: cloud-vmware.jar needs to be in the system vm for the
PremiumSecondaryStorageResource to work
Posted by disheng su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5804/#review9412
-----------------------------------------------------------
the agent package depends on vmware, if vmware hypervisor is used. We can't just add PremiumSecondaryStorageResource back into core, as it depends on vmware library, thus may break the apache license.
As we already build vmware separately, need a way to add vmware related jar files into agent.tgz, such as "ant package-agent-with-vmware"
- disheng su
On July 6, 2012, 11:50 a.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5804/
> -----------------------------------------------------------
>
> (Updated July 6, 2012, 11:50 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> PremiumSecondaryStorageResource depends on VmwareSecondaryStorageContextFactory and VmwareSecondaryStorageResourceHandler, which were move to cloud-vmware.jar
>
>
> Diffs
> -----
>
> build/build-cloud.xml b8ad09e
> build/package.xml 2b5a74b
>
> Diff: https://reviews.apache.org/r/5804/diff/
>
>
> Testing
> -------
>
> Create new zone
> Download template after ssvm has booted
>
>
> Thanks,
>
> Hugo Trippaers
>
>