You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/01 11:12:35 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3675: Update sqlparser to 0.24.0
alamb opened a new pull request, #3675:
URL: https://github.com/apache/arrow-datafusion/pull/3675
# Which issue does this PR close?
Re https://github.com/apache/arrow-datafusion/issues/3606
# Rationale for this change
Upgrade to get support for explain plan format (e.g. `explain graphviz`)
# What changes are included in this PR?
1. Upgrade dependency
2. Update code to use new code
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #3675: Update sqlparser to 0.24.0
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3675:
URL: https://github.com/apache/arrow-datafusion/pull/3675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on pull request #3675: Update sqlparser to 0.24.0
Posted by GitBox <gi...@apache.org>.
xudong963 commented on PR #3675:
URL: https://github.com/apache/arrow-datafusion/pull/3675#issuecomment-1264341098
https://github.com/apache/arrow-datafusion/actions/runs/3164334070/jobs/5152557761
Other PRs also encountered the issue :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3675: Update sqlparser to 0.24.0
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3675:
URL: https://github.com/apache/arrow-datafusion/pull/3675#issuecomment-1264484983
> https://github.com/apache/arrow-datafusion/actions/runs/3164334070/jobs/5152557761
Other PRs also encountered the issue :/
🤔 maybe we have hit the space limit on the builders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3675: Update sqlparser to 0.24.0
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3675:
URL: https://github.com/apache/arrow-datafusion/pull/3675#issuecomment-1264622129
Filed https://github.com/apache/arrow-datafusion/issues/3678 for the CI failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3675: Update sqlparser to 0.24.0
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3675:
URL: https://github.com/apache/arrow-datafusion/pull/3675#discussion_r985086988
##########
datafusion/sql/src/planner.rs:
##########
@@ -152,6 +152,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
verbose,
statement,
analyze,
+ format: _,
Review Comment:
here is the support for explain plan format
##########
datafusion/sql/src/planner.rs:
##########
@@ -1720,22 +1721,22 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
],
}),
- SQLExpr::Value(Value::Interval {
+ SQLExpr::Array(arr) => self.sql_array_literal(arr.elem, schema),
+
+ SQLExpr::Interval {
Review Comment:
Intervals are no longer literals (`Value`) but can have exprs so the AST was updated to match in https://github.com/sqlparser-rs/sqlparser-rs/pull/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3675: Update sqlparser to 0.24.0
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3675:
URL: https://github.com/apache/arrow-datafusion/pull/3675#issuecomment-1265418040
Benchmark runs are scheduled for baseline = c9b26cc962a705a09434330092f2f21824a47562 and contender = f706902bcb5e016900e49fc970c0c8fe96fbd219. f706902bcb5e016900e49fc970c0c8fe96fbd219 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7a7a6c4086874506a47f6ac6202a5618...03e9155d5b174a058d13d322b133e4e4/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/28e9553f328d4138ad56140ffcce2dc8...46d4f7d987204c0ab0d4cc6abca3e2a0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/92755ea091de4133babd95949a97c74d...32bb8cc63a514544b78d6919b39ea4bc/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bf312de78a734744beaf715110e888fc...08141f837b3c48d7a6777cddecf42147/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org