You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/12/16 20:06:25 UTC

[GitHub] [trafficserver] maskit commented on a diff in pull request #9258: Remove cqhv log field

maskit commented on code in PR #9258:
URL: https://github.com/apache/trafficserver/pull/9258#discussion_r1051118085


##########
proxy/logging/LogAccess.cc:
##########
@@ -917,7 +917,7 @@ LogAccess::unmarshal_http_version(char **buf, char *dest, int len)
   LogAccess::unmarshal_http_text
 
   The http text is simply the fields http_method (cqhm) + url (pqu) +
-  http_version (cqhv), all right next to each other, in that order.
+  http_version (cqhv, which was removed on 10.0.0), all right next to each other, in that order.

Review Comment:
   Yea, I thought about it, but I was too lazy. How about this:
   > The http text is a reproduced HTTP/1.x request line. It's HTTP method (cqhm) + URL (pqu) + HTTP version. This doesn't support HTTP/2 and HTTP/3 since those don't have a request line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org