[GitHub] [lucene] uschindler commented on pull request #638: LUCENE-10393: Unify resource loader in kuromoji and nori

[GitBox <gi...@apache.org>]

uschindler commented on pull request #638:
URL: https://github.com/apache/lucene/pull/638#issuecomment-1028771777


   > Please don't do the current code or add opens. Just simple remove the DictionaryLoader class completely and just use getResourceAsStream() directly. Most important: Remove the ENUM, its a misnomer anyways (CLASSPATH is incorrect).
   
   This is exactly the same: Never ever delegate opening class' resources to other code. Call getResourceAsStream() from the class that wants to load the files and where they reside. Don't add abstractions: ConnectionCosts class should call getResourceAsStream in its own code and load the file placed next to the class in JAR.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org