[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113164#comment-16113164 ] 

ASF GitHub Bot commented on TWILL-240:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/58#discussion_r131209163
  
    --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java ---
    @@ -135,6 +135,15 @@
       private final Map<String, Map<String, String>> environments;
       private final TwillRuntimeSpecification twillRuntimeSpec;
     
    +  /**
    +   * Final status of this service when it stops.
    +   */
    +  public enum FinalStatus {
    --- End diff --
    
    Sounds more like `StopStatus` or `CompletionStatus`. Also it should be `private` since it is only used in this class.
    
    Also, please move it before all fields declaration instead of having it in between fields.


> Improve EventHandler to handle more application lifecycle events
> ----------------------------------------------------------------
>
>                 Key: TWILL-240
>                 URL: https://issues.apache.org/jira/browse/TWILL-240
>             Project: Apache Twill
>          Issue Type: New Feature
>            Reporter: Chengfeng Mao
>            Assignee: Chengfeng Mao
>
> Application Master should be able to run application specific code when certain lifecycle events happen by calling methods from EventHandler. For instance, when the app first starts, completes, aborts and etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)