You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/19 01:48:56 UTC

[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2761: [Feature][ST-Engine] Add CoordinatorService & Coordinator can reinit when Master Node actived

EricJoy2048 commented on code in PR #2761:
URL: https://github.com/apache/incubator-seatunnel/pull/2761#discussion_r973816942


##########
seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/TaskExecutionServiceTest.java:
##########
@@ -64,20 +64,21 @@ public void before() {
     @Test
     public void testAll() throws InterruptedException {
         logger.info("----------start Cancel test----------");
-        testCancel();
+        //testCancel();

Review Comment:
   > Hi, why remove these method?
   
   As we have more and more test cases, the container load for testing will become higher, and these test cases will make errors. @ic4y  will fix these problems in the following pr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org