You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2017/10/04 09:07:08 UTC
[GitHub] activemq-artemis pull request #1569: ARTEMIS-1446 - Support Transformer conf...
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1569
ARTEMIS-1446 - Support Transformer configuration by properties
Update Tranformer to be able to handle initiation via propertiers (map<string, string>)
Update Configuration to have more specific transfromer configuration type, and to take properties.
Support back compatibility.
Add AddHeadersTransformer which is a main use case, and can act as example also.
Update Control's to expose new property configuration
Add test cases
Update examples for new transformer config style
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1446
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1569
----
commit 2a3cedd18d9b2637101a8464d586ee70f3f82380
Author: Michael Andre Pearce <mi...@me.com>
Date: 2017-09-27T19:01:29Z
ARTEMIS-1446 - Support Transformer configuration by properties
Update Tranformer to be able to handle initiation via propertiers (map<string, string>)
Update Configuration to have more specific transfromer configuration type, and to take properties.
Support back compatibility.
Add AddHeadersTransformer which is a main use case, and can act as example also.
Update Control's to expose new property configuration
Add test cases
Update examples for new transformer config style
----
---
[GitHub] activemq-artemis issue #1569: ARTEMIS-1446 - Support Transformer configurati...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1569
@jbertram good point, i think the standard looking at other controls is to output JSON string form. Have updated so it returns a String in JSON representation.
---
[GitHub] activemq-artemis issue #1569: ARTEMIS-1446 - Support Transformer configurati...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1569
This looks good, but I'm a bit concerned about using a Map in the management methods as this will preclude the use of tools like JVisualVM, JConsole, Jolokia, etc. to invoke those methods as they have no way to represent a Map in plain text. Perhaps consider using a comma delimited String of key=value pairs instead of Map for the management methods.
---
[GitHub] activemq-artemis issue #1569: ARTEMIS-1446 - Support Transformer configurati...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1569
Background small discussion on dev mail list http://activemq-dev.markmail.org/message/sunyg6rohsplus7e?q=properties+bridge suggesting to use properties (ala map<string,string>)
---
[GitHub] activemq-artemis pull request #1569: ARTEMIS-1446 - Support Transformer conf...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1569
---