You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by Reto Bachmann-Gmür <re...@apache.org> on 2012/12/10 21:45:03 UTC
Could somebody review and commit my patch for WINK-375?
Hi,
It would be good if my patch for
https://issues.apache.org/jira/browse/WINK-375 could be reviewd and
hopefully accpeted.
It's a short patch but working around the issue would be quite tedious so
it would be great if this could make it into trunk and snapshot would be
available in the snapshot repository.
Cheers,
Reto
Re: Could somebody review and commit my patch for WINK-375?
Posted by Reto Bachmann-Gmür <re...@wymiwyg.com>.
On Wed, Dec 12, 2012 at 5:57 AM, Luciano Resende <lu...@gmail.com>wrote:
> On Tue, Dec 11, 2012 at 12:23 PM, Reto Bachmann-Gmür <reto@apache.org
> >wrote:
>
> > On Tue, Dec 11, 2012 at 8:06 PM, Luciano Resende <luckbr1975@gmail.com
> > >wrote:
> >
> > > I'll look at it, but as far as I remember, there is a downstream job to
> > > deploy, which is not being invoked because the top level build is
> > failing.
> > >
> >
> > On https://builds.apache.org/job/Wink-Trunk-JDK1.5/configure I see no
> such
> > post-build action. And while less elegant I know from other projects that
> > replacing install with deploy works.
> >
> >
> Please go ahead with the changes. BTW, do we want to publish the build
> artifacts from the 1.5 or 1.6 jdk build ?
>
I changed Wink-Trunk-JDK1.6. Let's see if it works. It might need a bit
more heap in maven_opts.
Reto
Re: Could somebody review and commit my patch for WINK-375?
Posted by Luciano Resende <lu...@gmail.com>.
On Tue, Dec 11, 2012 at 12:23 PM, Reto Bachmann-Gmür <re...@apache.org>wrote:
> On Tue, Dec 11, 2012 at 8:06 PM, Luciano Resende <luckbr1975@gmail.com
> >wrote:
>
> > I'll look at it, but as far as I remember, there is a downstream job to
> > deploy, which is not being invoked because the top level build is
> failing.
> >
>
> On https://builds.apache.org/job/Wink-Trunk-JDK1.5/configure I see no such
> post-build action. And while less elegant I know from other projects that
> replacing install with deploy works.
>
>
Please go ahead with the changes. BTW, do we want to publish the build
artifacts from the 1.5 or 1.6 jdk build ?
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Could somebody review and commit my patch for WINK-375?
Posted by Reto Bachmann-Gmür <re...@apache.org>.
On Tue, Dec 11, 2012 at 8:06 PM, Luciano Resende <lu...@gmail.com>wrote:
> I'll look at it, but as far as I remember, there is a downstream job to
> deploy, which is not being invoked because the top level build is failing.
>
On https://builds.apache.org/job/Wink-Trunk-JDK1.5/configure I see no such
post-build action. And while less elegant I know from other projects that
replacing install with deploy works.
>
> On Tuesday, December 11, 2012, Reto Bachmann-Gmür wrote:
>
> > I've noticed than jenkins is configured to just do: mvn clean install.
> > If it would be configured to execte: `mvn clean deploy`instead, the
> > artifacts would be deployed to the snapshot repositiry.
> >
> > Would you mind chnaging this? (it seems I could change this as well. not
> > sure if there per project access restrictions on jenkins)
> >
> > Reteo
> >
> > On Tue, Dec 11, 2012 at 4:54 PM, Luciano Resende <luckbr1975@gmail.com
> <javascript:;>
> > >wrote:
> >
> > > On Tuesday, December 11, 2012, Reto Bachmann-Gmür wrote:
> > >
> > > > On 11 Dec 2012 07:15, "Luciano Resende" <luckbr1975@gmail.com
> <javascript:;>
> > > <javascript:;>>
> > > > wrote:
> > > > >
> > > > > On Mon, Dec 10, 2012 at 12:45 PM, Reto Bachmann-Gmür <
> > reto@apache.org <javascript:;>
> > > <javascript:;>
> > > > >wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > It would be good if my patch for
> > > > > > https://issues.apache.org/jira/browse/WINK-375 could be reviewd
> > and
> > > > > > hopefully accpeted.
> > > > > >
> > > > > > It's a short patch but working around the issue would be quite
> > > tedious
> > > > so
> > > > > > it would be great if this could make it into trunk and snapshot
> > would
> > > > be
> > > > > > available in the snapshot repository.
> > > > > >
> > > > > > Cheers,
> > > > > > Reto
> > > > > >
> > > > >
> > > > > Figuring out some build issues, and would apply the patch.
> > > >
> > > > Thanks. Are you referring to the issue seen on Jenkins? I can't see
> the
> > > > link to the build problem in Thrift Provider.
> > > >
> > > > Reto
> > > >
> > >
> > > No, I was having an issue building in my mac/java 7 env.... But tested
> > back
> > > in linux/java 6 and all seems ok... So not related to the patch you
> > > provided.
> > >
> > >
> > > --
> > > Luciano Resende
> > > http://people.apache.org/~lresende
> > > http://twitter.com/lresende1975
> > > http://lresende.blogspot.com/
> > >
> >
>
>
> --
> Luciano Resende
> http://people.apache.org/~lresende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
>
Re: Could somebody review and commit my patch for WINK-375?
Posted by Luciano Resende <lu...@gmail.com>.
I'll look at it, but as far as I remember, there is a downstream job to
deploy, which is not being invoked because the top level build is failing.
On Tuesday, December 11, 2012, Reto Bachmann-Gmür wrote:
> I've noticed than jenkins is configured to just do: mvn clean install.
> If it would be configured to execte: `mvn clean deploy`instead, the
> artifacts would be deployed to the snapshot repositiry.
>
> Would you mind chnaging this? (it seems I could change this as well. not
> sure if there per project access restrictions on jenkins)
>
> Reteo
>
> On Tue, Dec 11, 2012 at 4:54 PM, Luciano Resende <luckbr1975@gmail.com<javascript:;>
> >wrote:
>
> > On Tuesday, December 11, 2012, Reto Bachmann-Gmür wrote:
> >
> > > On 11 Dec 2012 07:15, "Luciano Resende" <luckbr1975@gmail.com<javascript:;>
> > <javascript:;>>
> > > wrote:
> > > >
> > > > On Mon, Dec 10, 2012 at 12:45 PM, Reto Bachmann-Gmür <
> reto@apache.org <javascript:;>
> > <javascript:;>
> > > >wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > It would be good if my patch for
> > > > > https://issues.apache.org/jira/browse/WINK-375 could be reviewd
> and
> > > > > hopefully accpeted.
> > > > >
> > > > > It's a short patch but working around the issue would be quite
> > tedious
> > > so
> > > > > it would be great if this could make it into trunk and snapshot
> would
> > > be
> > > > > available in the snapshot repository.
> > > > >
> > > > > Cheers,
> > > > > Reto
> > > > >
> > > >
> > > > Figuring out some build issues, and would apply the patch.
> > >
> > > Thanks. Are you referring to the issue seen on Jenkins? I can't see the
> > > link to the build problem in Thrift Provider.
> > >
> > > Reto
> > >
> >
> > No, I was having an issue building in my mac/java 7 env.... But tested
> back
> > in linux/java 6 and all seems ok... So not related to the patch you
> > provided.
> >
> >
> > --
> > Luciano Resende
> > http://people.apache.org/~lresende
> > http://twitter.com/lresende1975
> > http://lresende.blogspot.com/
> >
>
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Could somebody review and commit my patch for WINK-375?
Posted by Reto Bachmann-Gmür <re...@apache.org>.
I've noticed than jenkins is configured to just do: mvn clean install.
If it would be configured to execte: `mvn clean deploy`instead, the
artifacts would be deployed to the snapshot repositiry.
Would you mind chnaging this? (it seems I could change this as well. not
sure if there per project access restrictions on jenkins)
Reteo
On Tue, Dec 11, 2012 at 4:54 PM, Luciano Resende <lu...@gmail.com>wrote:
> On Tuesday, December 11, 2012, Reto Bachmann-Gmür wrote:
>
> > On 11 Dec 2012 07:15, "Luciano Resende" <luckbr1975@gmail.com
> <javascript:;>>
> > wrote:
> > >
> > > On Mon, Dec 10, 2012 at 12:45 PM, Reto Bachmann-Gmür <reto@apache.org
> <javascript:;>
> > >wrote:
> > >
> > > > Hi,
> > > >
> > > > It would be good if my patch for
> > > > https://issues.apache.org/jira/browse/WINK-375 could be reviewd and
> > > > hopefully accpeted.
> > > >
> > > > It's a short patch but working around the issue would be quite
> tedious
> > so
> > > > it would be great if this could make it into trunk and snapshot would
> > be
> > > > available in the snapshot repository.
> > > >
> > > > Cheers,
> > > > Reto
> > > >
> > >
> > > Figuring out some build issues, and would apply the patch.
> >
> > Thanks. Are you referring to the issue seen on Jenkins? I can't see the
> > link to the build problem in Thrift Provider.
> >
> > Reto
> >
>
> No, I was having an issue building in my mac/java 7 env.... But tested back
> in linux/java 6 and all seems ok... So not related to the patch you
> provided.
>
>
> --
> Luciano Resende
> http://people.apache.org/~lresende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
>
Re: Could somebody review and commit my patch for WINK-375?
Posted by Luciano Resende <lu...@gmail.com>.
On Tuesday, December 11, 2012, Reto Bachmann-Gmür wrote:
> On 11 Dec 2012 07:15, "Luciano Resende" <luckbr1975@gmail.com<javascript:;>>
> wrote:
> >
> > On Mon, Dec 10, 2012 at 12:45 PM, Reto Bachmann-Gmür <reto@apache.org<javascript:;>
> >wrote:
> >
> > > Hi,
> > >
> > > It would be good if my patch for
> > > https://issues.apache.org/jira/browse/WINK-375 could be reviewd and
> > > hopefully accpeted.
> > >
> > > It's a short patch but working around the issue would be quite tedious
> so
> > > it would be great if this could make it into trunk and snapshot would
> be
> > > available in the snapshot repository.
> > >
> > > Cheers,
> > > Reto
> > >
> >
> > Figuring out some build issues, and would apply the patch.
>
> Thanks. Are you referring to the issue seen on Jenkins? I can't see the
> link to the build problem in Thrift Provider.
>
> Reto
>
No, I was having an issue building in my mac/java 7 env.... But tested back
in linux/java 6 and all seems ok... So not related to the patch you
provided.
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Could somebody review and commit my patch for WINK-375?
Posted by Reto Bachmann-Gmür <re...@wymiwyg.com>.
On 11 Dec 2012 07:15, "Luciano Resende" <lu...@gmail.com> wrote:
>
> On Mon, Dec 10, 2012 at 12:45 PM, Reto Bachmann-Gmür <reto@apache.org
>wrote:
>
> > Hi,
> >
> > It would be good if my patch for
> > https://issues.apache.org/jira/browse/WINK-375 could be reviewd and
> > hopefully accpeted.
> >
> > It's a short patch but working around the issue would be quite tedious
so
> > it would be great if this could make it into trunk and snapshot would be
> > available in the snapshot repository.
> >
> > Cheers,
> > Reto
> >
>
> Figuring out some build issues, and would apply the patch.
Thanks. Are you referring to the issue seen on Jenkins? I can't see the
link to the build problem in Thrift Provider.
Reto
Re: Could somebody review and commit my patch for WINK-375?
Posted by Luciano Resende <lu...@gmail.com>.
On Mon, Dec 10, 2012 at 12:45 PM, Reto Bachmann-Gmür <re...@apache.org>wrote:
> Hi,
>
> It would be good if my patch for
> https://issues.apache.org/jira/browse/WINK-375 could be reviewd and
> hopefully accpeted.
>
> It's a short patch but working around the issue would be quite tedious so
> it would be great if this could make it into trunk and snapshot would be
> available in the snapshot repository.
>
> Cheers,
> Reto
>
Figuring out some build issues, and would apply the patch.
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/