You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/15 08:08:14 UTC
[GitHub] [dubbo-go] fangyincheng opened a new pull request #877: Fix heartbeat
fangyincheng opened a new pull request #877:
URL: https://github.com/apache/dubbo-go/pull/877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #877: Fix heartbeat
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #877:
URL: https://github.com/apache/dubbo-go/pull/877#issuecomment-727541263
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=h1) Report
> Merging [#877](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=desc) (f22ffdd) into [master](https://codecov.io/gh/apache/dubbo-go/commit/e928956c1acc01edd47c405c05991e0200fd912f?el=desc) (e928956) will **increase** coverage by `0.14%`.
> The diff coverage is `52.17%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #877 +/- ##
==========================================
+ Coverage 60.02% 60.17% +0.14%
==========================================
Files 260 260
Lines 12795 12807 +12
==========================================
+ Hits 7680 7706 +26
+ Misses 4154 4144 -10
+ Partials 961 957 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.09% <38.88%> (-2.40%)` | :arrow_down: |
| [cluster/cluster\_impl/forking\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyX2ludm9rZXIuZ28=) | `56.25% <100.00%> (ø)` | |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `87.75% <100.00%> (ø)` | |
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <100.00%> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `43.66% <0.00%> (+0.70%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `53.68% <0.00%> (+3.15%)` | :arrow_up: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `63.41% <0.00%> (+4.06%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `71.36% <0.00%> (+7.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=footer). Last update [e928956...55d69fe](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #877: Fix heartbeat
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #877:
URL: https://github.com/apache/dubbo-go/pull/877#issuecomment-727541263
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=h1) Report
> Merging [#877](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=desc) (55d69fe) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #877 +/- ##
===========================================
- Coverage 60.17% 60.11% -0.06%
===========================================
Files 260 260
Lines 12807 12808 +1
===========================================
- Hits 7706 7699 -7
- Misses 4144 4152 +8
Partials 957 957
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `41.95% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (-1.77%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/877/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=footer). Last update [f22ffdd...55d69fe](https://codecov.io/gh/apache/dubbo-go/pull/877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #877: Fix: using close to defeat block on hearbeat pendingResponse.done
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #877:
URL: https://github.com/apache/dubbo-go/pull/877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org