You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/02/24 13:35:35 UTC
[GitHub] [rocketmq-externals] maixiaohai opened a new pull request #683: [ISSUE #682] Fix wrong message trace detail
maixiaohai opened a new pull request #683:
URL: https://github.com/apache/rocketmq-externals/pull/683
## What is the purpose of the change
issue #682
## Brief changelog
1. add client host field
2. add compatbile logic when decode trace msg
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on a change in pull request #683: [ISSUE #682] Fix wrong message trace detail
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #683:
URL: https://github.com/apache/rocketmq-externals/pull/683#discussion_r584018855
##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/util/MsgTraceDecodeUtil.java
##########
@@ -54,12 +66,29 @@
pubContext.setCostTime(Integer.parseInt(line[10]));
bean.setMsgType(MessageType.values()[Integer.parseInt(line[11])]);
- if (line.length == 13) {
- pubContext.setSuccess(Boolean.parseBoolean(line[12]));
- } else if (line.length == 14) {
- bean.setOffsetMsgId(line[12]);
- pubContext.setSuccess(Boolean.parseBoolean(line[13]));
+ // compatible with different version
+ switch (line.length) {
+ case TRACE_MSG_PUB_V1_LEN:
+ break;
Review comment:
Make some tests for the switch case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] maixiaohai commented on a change in pull request #683: [ISSUE #682] Fix wrong message trace detail
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on a change in pull request #683:
URL: https://github.com/apache/rocketmq-externals/pull/683#discussion_r590366843
##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/util/MsgTraceDecodeUtil.java
##########
@@ -88,9 +118,24 @@
subAfterContext.getTraceBeans().add(bean);
subAfterContext.setCostTime(Integer.parseInt(line[3]));
subAfterContext.setSuccess(Boolean.parseBoolean(line[4]));
- if (line.length >= 7) {
- // add the context type
- subAfterContext.setContextCode(Integer.parseInt(line[6]));
+ // compatible with different version
+ switch (line.length) {
+ case TRACE_MSG_SUBAFTER_V1_LEN:
+ break;
+ case TRACE_MSG_SUBAFTER_V2_LEN:
+ subAfterContext.setContextCode(Integer.parseInt(line[6]));
+ break;
+ case TRACE_MSG_SUBAFTER_V3_LEN:
+ subAfterContext.setContextCode(Integer.parseInt(line[6]));
+ subAfterContext.setTimeStamp(Long.parseLong(line[7]));
+ subAfterContext.setGroupName(line[8]);
+ break;
+ default:
Review comment:
default logic is compatible for new version subAfterType.
If a new field is added to subAfter message, the length will greater than TRACE_MSG_SUBAFTER_V3_LEN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on pull request #683: [ISSUE #682] Fix wrong message trace detail
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #683:
URL: https://github.com/apache/rocketmq-externals/pull/683#issuecomment-796576285
Great, TraceDataEncoder still need to polish ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on a change in pull request #683: [ISSUE #682] Fix wrong message trace detail
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #683:
URL: https://github.com/apache/rocketmq-externals/pull/683#discussion_r582437957
##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/util/MsgTraceDecodeUtil.java
##########
@@ -92,6 +100,11 @@
// add the context type
subAfterContext.setContextCode(Integer.parseInt(line[6]));
}
+ // compatible with the old version
+ if (line.length >= 9) {
Review comment:
Could we use the constant while not a number(such as 9 or 15)to be forward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling commented on a change in pull request #683: [ISSUE #682] Fix wrong message trace detail
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #683:
URL: https://github.com/apache/rocketmq-externals/pull/683#discussion_r590271255
##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/util/MsgTraceDecodeUtil.java
##########
@@ -88,9 +118,24 @@
subAfterContext.getTraceBeans().add(bean);
subAfterContext.setCostTime(Integer.parseInt(line[3]));
subAfterContext.setSuccess(Boolean.parseBoolean(line[4]));
- if (line.length >= 7) {
- // add the context type
- subAfterContext.setContextCode(Integer.parseInt(line[6]));
+ // compatible with different version
+ switch (line.length) {
+ case TRACE_MSG_SUBAFTER_V1_LEN:
+ break;
+ case TRACE_MSG_SUBAFTER_V2_LEN:
+ subAfterContext.setContextCode(Integer.parseInt(line[6]));
+ break;
+ case TRACE_MSG_SUBAFTER_V3_LEN:
+ subAfterContext.setContextCode(Integer.parseInt(line[6]));
+ subAfterContext.setTimeStamp(Long.parseLong(line[7]));
+ subAfterContext.setGroupName(line[8]);
+ break;
+ default:
Review comment:
What's the difference between TRACE_MSG_SUBAFTER_V1_LEN and default logic, It is correct here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] maixiaohai commented on pull request #683: [ISSUE #682] Fix wrong message trace detail
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on pull request #683:
URL: https://github.com/apache/rocketmq-externals/pull/683#issuecomment-790281074
soft ping~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling merged pull request #683: [ISSUE #682] Fix wrong message trace detail
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #683:
URL: https://github.com/apache/rocketmq-externals/pull/683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org