You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/10 15:05:40 UTC

[GitHub] [cloudstack] div8cn opened a new pull request #3959: fix Volume migration across pools sometimes loses volume

div8cn opened a new pull request #3959: fix Volume migration across pools sometimes loses volume
URL: https://github.com/apache/cloudstack/pull/3959
 
 
   ## Description
   <!--- Describe your changes in detail -->
   When secondary storage usage is> 90%, VOLUME migration across primary storage will cause the migration to fail and lose VOLUME
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   3958
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3959: fix Volume migration across pools sometimes loses volume

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3959: fix Volume migration across pools sometimes loses volume
URL: https://github.com/apache/cloudstack/pull/3959#discussion_r390407552
 
 

 ##########
 File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
 ##########
 @@ -486,6 +486,9 @@ public void copyAsync(DataObject srcData, DataObject destData, Host destHost, As
             if (answer != null && !answer.getResult()) {
                 errMsg = answer.getDetails();
             }
+            if (answer == null) {
+                errMsg = "answer is null, set to error for CopyCommandResult";
 
 Review comment:
   I don't understand this error message. Can you make it very clear, please?
   for example "no answer from came back from copyCommand, considering it as failed."
   preferably even with some data like src, dest, src.type and dest.type

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services