You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/05/11 06:31:00 UTC

[GitHub] carbondata pull request #2293: [CARBONDATA-2468] addition of column to defau...

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2293#discussion_r187530228
  
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
    @@ -481,9 +482,13 @@ private void buildTableSchema(Field[] fields, TableSchemaBuilder tableSchemaBuil
               ColumnSchema columnSchema = tableSchemaBuilder
                   .addColumn(new StructField(field.getFieldName(), field.getDataType()),
                       valIndex, isSortColumn > -1);
    -          columnSchema.setSortColumn(true);
               if (isSortColumn > -1) {
    +            columnSchema.setSortColumn(true);
                 sortColumnsSchemaList[isSortColumn] = columnSchema;
    +          } else if (sortColumnsList.isEmpty() && columnSchema.isDimensionColumn()) {
    --- End diff --
    
    Complex column and it's children should not be considered as sort column, please handle the same


---