You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/29 01:44:57 UTC

[GitHub] Mogball commented on a change in pull request #3949: [Bugfix] Druid `run_query` dimensions part 3 + Unit tests

Mogball commented on a change in pull request #3949: [Bugfix] Druid `run_query` dimensions part 3 + Unit tests
URL: https://github.com/apache/incubator-superset/pull/3949#discussion_r153675241
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -898,7 +898,7 @@ def run_query(  # noqa / druid
             row_limit=None,
             inner_from_dttm=None, inner_to_dttm=None,
             orderby=None,
-            extras=None,  # noqa
+            extras={},  # noqa
 
 Review comment:
   ? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services