You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/10 17:17:34 UTC
[GitHub] [maven] michael-o commented on a diff in pull request #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.
michael-o commented on code in PR #869:
URL: https://github.com/apache/maven/pull/869#discussion_r1019414975
##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,
final CommandLine commandLine,
final MavenExecutionRequest request )
{
- if ( quiet || commandLine.hasOption( CLIManager.NO_TRANSFER_PROGRESS ) )
+ String ciEnv = request.getSystemProperties().getProperty( "env.CI" );
+ boolean quietCI = "true".equals( ciEnv ) && !commandLine.hasOption( FORCE_INTERACTIVE );
Review Comment:
This is not the way the value is defined.
##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,
final CommandLine commandLine,
final MavenExecutionRequest request )
{
- if ( quiet || commandLine.hasOption( CLIManager.NO_TRANSFER_PROGRESS ) )
+ String ciEnv = request.getSystemProperties().getProperty( "env.CI" );
+ boolean quietCI = "true".equals( ciEnv ) && !commandLine.hasOption( FORCE_INTERACTIVE );
Review Comment:
This is not the way the variable is defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org