You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org> on 2006/10/30 02:11:18 UTC

[jira] Created: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
-------------------------------------------------------------------------------

                 Key: ADFFACES-270
                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
             Project: MyFaces ADF-Faces
          Issue Type: Improvement
            Reporter: Arjuna Wijeyekoon


We recently introduced the ClientRowKeyManager api.
Now we need to rename the old methods:
get/setCurrencyString
on UIXCollection
to get/setClientRowKey
as it makes more sense.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon updated ADFFACES-270:
---------------------------------------

    Status: Open  (was: Patch Available)

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Reopened: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon reopened ADFFACES-270:
----------------------------------------

             
I forgot to deprecate the
UIXCollection.clearCurrencyStringCache()
method.

I also forgot to add javadoc to the 
UIXCollection.getClientRowKeyManager()
method.

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon updated ADFFACES-270:
---------------------------------------

    Attachment: add_javadoc_and_deprecation_2_uixCollection.patch

ok, please use the attached patch called
add_javadoc_and_deprecation_2_uixCollection.patch

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: add_javadoc_and_deprecation_2_uixCollection.patch, rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Assigned: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Matthias Weßendorf reassigned ADFFACES-270:
-------------------------------------------

    Assignee: Matthias Weßendorf

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated ADFFACES-270:
----------------------------------------

        Fix Version/s: 1.0.0-incubating-core
    Affects Version/s: 1.0.0-incubating-core

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>    Affects Versions: 1.0.0-incubating-core
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>             Fix For: 1.0.0-incubating-core
>
>         Attachments: add_javadoc_and_deprecation_2_uixCollection.patch, rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon updated ADFFACES-270:
---------------------------------------

    Attachment:     (was: add_javadoc_and_deprecation_2_uixCollection.patch)

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Closed: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Matthias Weßendorf closed ADFFACES-270.
---------------------------------------

    Resolution: Fixed

commited to svn. thx arj.

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Adam Winer updated ADFFACES-270:
--------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

Checked in patch.

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: add_javadoc_and_deprecation_2_uixCollection.patch, rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-270?page=comments#action_12448352 ] 
            
Arjuna Wijeyekoon commented on ADFFACES-270:
--------------------------------------------

please use the patch labeled:
add_javadoc_and_deprecation_2_uixCollection.patch
to close this issue

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: add_javadoc_and_deprecation_2_uixCollection.patch, rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon updated ADFFACES-270:
---------------------------------------

    Attachment: rename_currentStr_to_clientRowKey.patch

I've attached a patch that introduces the new methods
get/setClientRowKey

I will give 3rd parties a few days to migrate, and then I will
upload a new patch that removes the old
get/setCurrencyStrings (which are marked as deprecated now)

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Attachments: rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon updated ADFFACES-270:
---------------------------------------

    Status: Patch Available  (was: Open)

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Attachments: rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon updated ADFFACES-270:
---------------------------------------

    Status: Patch Available  (was: Reopened)

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: add_javadoc_and_deprecation_2_uixCollection.patch, rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon updated ADFFACES-270:
---------------------------------------

    Attachment: add_javadoc_and_deprecation_2_uixCollection.patch

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: add_javadoc_and_deprecation_2_uixCollection.patch, rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-270?page=comments#action_12448542 ] 
            
Arjuna Wijeyekoon commented on ADFFACES-270:
--------------------------------------------

wait, I cancelled the patch.
need to add @Deprecated annotation.

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (ADFFACES-270) UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey

Posted by "Arjuna Wijeyekoon (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-270?page=all ]

Arjuna Wijeyekoon updated ADFFACES-270:
---------------------------------------

    Status: Patch Available  (was: Open)

> UIXCollection api cleanup - rename get/setCurrencyString to get/setClientRowKey
> -------------------------------------------------------------------------------
>
>                 Key: ADFFACES-270
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-270
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Arjuna Wijeyekoon
>         Assigned To: Matthias Weßendorf
>         Attachments: add_javadoc_and_deprecation_2_uixCollection.patch, rename_currentStr_to_clientRowKey.patch
>
>
> We recently introduced the ClientRowKeyManager api.
> Now we need to rename the old methods:
> get/setCurrencyString
> on UIXCollection
> to get/setClientRowKey
> as it makes more sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira