You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/04/14 18:10:58 UTC

[GitHub] flink pull request: Add util for TDD instantiation

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1890

    Add util for TDD instantiation

    This PR is more of a proposal and tries to make TaskDeploymentDescriptor instantiation in tests less tedious.
    
    With a total of 17/18 constructor arguments calling the constructor naturally becomes an unreadable affair. As such i added a TaskDeploymentDescriptorBuilder with a set method for every argument; should an argument not be set when build() is called a default value is used.
    
    I recently tried adding the job name to the TDD and when i saw the number of occurrences i would have to change I came up with this idea.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink refactor_tdd_test_instantiation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1890
    
----
commit 8d9261821b013e11cd799347d065663319bfa6c3
Author: zentol <ch...@apache.org>
Date:   2016-04-14T15:53:35Z

    Add util for TDD instantiation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #1890: Add util for TDD instantiation

Posted by zentol <gi...@git.apache.org>.

Github user zentol closed the pull request at:

    https://github.com/apache/flink/pull/1890


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #1890: Add util for TDD instantiation

Posted by uce <gi...@git.apache.org>.

Github user uce commented on the issue:

    https://github.com/apache/flink/pull/1890
  
    Still like the idea, but we didn't get any feedback and the TDD changed in the mean time. The number of arguments also decreased to 10. I think it's best to close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: Add util for TDD instantiation

Posted by uce <gi...@git.apache.org>.

Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1890#issuecomment-214338353
  
    I like this Chesnay. Definitely makes the tests more readable. Feel free to merge it if more people think this is useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---