You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/10/23 20:14:46 UTC

[kudu-CR] [rpc] more diagnostics on rpc-test assertions

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25207


Change subject: [rpc] more diagnostics on rpc-test assertions
......................................................................

[rpc] more diagnostics on rpc-test assertions

This changelist doesn't contain any functional modifications.

Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 13 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/25207/1
-- 
To view, visit http://gerrit.cloudera.org:8080/25207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [rpc] more diagnostics on rpc-test assertions

Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/25207 )

Change subject: [rpc] more diagnostics on rpc-test assertions
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/25207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Oct 2026 13:07:54 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] more diagnostics on rpc-test assertions

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25207 )

Change subject: [rpc] more diagnostics on rpc-test assertions
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/3146/


-- 
To view, visit http://gerrit.cloudera.org:8080/25207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 23 Oct 2026 20:14:52 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] more diagnostics on rpc-test assertions

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25207 )

Change subject: [rpc] more diagnostics on rpc-test assertions
......................................................................


Patch Set 1: Verified+1

unrelated failures of known flaky tests:
  * RELASE: KUDU-3275
  * ASAN: KUDU-3058


-- 
To view, visit http://gerrit.cloudera.org:8080/25207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Oct 2026 02:22:00 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] more diagnostics on rpc-test assertions

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25207 )

Change subject: [rpc] more diagnostics on rpc-test assertions
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/3146/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/25207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Oct 2026 20:50:05 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] more diagnostics on rpc-test assertions

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [rpc] more diagnostics on rpc-test assertions
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/25207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [rpc] more diagnostics on rpc-test assertions

Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/25207 )

Change subject: [rpc] more diagnostics on rpc-test assertions
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/25207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Oct 2026 05:12:31 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] more diagnostics on rpc-test assertions

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25207 )

Change subject: [rpc] more diagnostics on rpc-test assertions
......................................................................

[rpc] more diagnostics on rpc-test assertions

This changelist doesn't contain any functional modifications.

Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Reviewed-on: http://gerrit.cloudera.org:8080/25207
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 13 insertions(+), 7 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Zoltan Martonka: Looks good to me, approved
  Gabriella Lotz: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/25207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia76a221aa0874b89cee2ee9f5afd8f676eea700f
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>