You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/03/16 23:34:21 UTC
[kudu-CR] release notes: some edits
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9703
to review the following change.
Change subject: release notes: some edits
......................................................................
release notes: some edits
- Some small wording improvements
- Moved 3-4-3 replication to new features since it seems large enough to
not just be an "improvement"
- Added a note that the 3-disks-per-replica change only affects new
replicas
- Stopped documenting the experimental flag which goes back to 3-2-3
replication since we'd like to remove it in the future, and we don't
know of any compelling reasons for someone to change it.
- Moved KUDU-2259 to "fixed issues" since it was seen as a bug
- Added a few explanations of the results of some fixes instead of the
implementations.
Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
---
M docs/release_notes.adoc
1 file changed, 46 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/9703/1
--
To view, visit http://gerrit.cloudera.org:8080/9703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] release notes: some edits
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9703 )
Change subject: release notes: some edits
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 17 Mar 2018 00:22:39 +0000
Gerrit-HasComments: No
[kudu-CR] release notes: some edits
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9703 )
Change subject: release notes: some edits
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 16 Mar 2018 23:45:29 +0000
Gerrit-HasComments: No
[kudu-CR] release notes: some edits
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9703 )
Change subject: release notes: some edits
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 17 Mar 2018 00:22:26 +0000
Gerrit-HasComments: No
[kudu-CR] release notes: some edits
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: release notes: some edits
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] release notes: some edits
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9703 )
Change subject: release notes: some edits
......................................................................
release notes: some edits
- Some small wording improvements
- Moved 3-4-3 replication to new features since it seems large enough to
not just be an "improvement"
- Added a note that the 3-disks-per-replica change only affects new
replicas
- Stopped documenting the experimental flag which goes back to 3-2-3
replication since we'd like to remove it in the future, and we don't
know of any compelling reasons for someone to change it.
- Moved KUDU-2259 to "fixed issues" since it was seen as a bug
- Added a few explanations of the results of some fixes instead of the
implementations.
Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
Reviewed-on: http://gerrit.cloudera.org:8080/9703
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M docs/release_notes.adoc
1 file changed, 46 insertions(+), 64 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/9703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] release notes: some edits
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9703 )
Change subject: release notes: some edits
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I944a302a7fe5c86d0204545157efb92407573e1e
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 16 Mar 2018 23:54:37 +0000
Gerrit-HasComments: No