You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@hotmail.com> on 2014/09/19 05:49:39 UTC
GitHub pull request process for committers
Hi,
I've written up a quick guide for how committers can merge pull requests from GitHub: https://cwiki.apache.org/confluence/display/HELIX/Merging+Pull+Requests
Let me know if you have any feedback or if anything isn't clear.
Kanak
Re: GitHub pull request process for committers
Posted by Henry Saputra <he...@gmail.com>.
To help reduce problems and mistakes probably could make script to
semi-automate the process?
On Thu, Sep 18, 2014 at 8:49 PM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
> Hi,
>
> I've written up a quick guide for how committers can merge pull requests from GitHub: https://cwiki.apache.org/confluence/display/HELIX/Merging+Pull+Requests
>
> Let me know if you have any feedback or if anything isn't clear.
>
> Kanak
RE: GitHub pull request process for committers
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
It's optional, but it helps with aesthetics when you have multi-commit pull requests where the commits after the first are just deltas due to code reviews.
But yeah, you don't have to do it if you don't want to.
Kanak
----------------------------------------
> Date: Thu, 18 Sep 2014 21:18:52 -0700
> Subject: Re: GitHub pull request process for committers
> From: g.kishore@gmail.com
> To: dev@helix.apache.org
>
> thanks Kanak. qq. why is this required?
>
> git rebase -i HEAD~N # Replace N with the number of commits in this pull
> request
> # In the interactive rebase, keep "pick" next to the first commit, and
> change "pick" to "fixup" for subsequent commits
> git push --force origin/master
>
>
>
>
> On Thu, Sep 18, 2014 at 8:49 PM, Kanak Biscuitwala <ka...@hotmail.com>
> wrote:
>
>> Hi,
>>
>> I've written up a quick guide for how committers can merge pull requests
>> from GitHub:
>> https://cwiki.apache.org/confluence/display/HELIX/Merging+Pull+Requests
>>
>> Let me know if you have any feedback or if anything isn't clear.
>>
>> Kanak
Re: GitHub pull request process for committers
Posted by kishore g <g....@gmail.com>.
thanks Kanak. qq. why is this required?
git rebase -i HEAD~N # Replace N with the number of commits in this pull
request
# In the interactive rebase, keep "pick" next to the first commit, and
change "pick" to "fixup" for subsequent commits
git push --force origin/master
On Thu, Sep 18, 2014 at 8:49 PM, Kanak Biscuitwala <ka...@hotmail.com>
wrote:
> Hi,
>
> I've written up a quick guide for how committers can merge pull requests
> from GitHub:
> https://cwiki.apache.org/confluence/display/HELIX/Merging+Pull+Requests
>
> Let me know if you have any feedback or if anything isn't clear.
>
> Kanak