You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Eric Waters (JIRA)" <ji...@apache.org> on 2009/07/30 00:43:14 UTC
[jira] Created: (THRIFT-554) Perl improper namespace check for
exception handling and writeMessageEnd missing on processor calls
Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls
---------------------------------------------------------------------------------------------------
Key: THRIFT-554
URL: https://issues.apache.org/jira/browse/THRIFT-554
Project: Thrift
Issue Type: Bug
Components: Compiler (Perl)
Environment: Ubuntu Jaunty x86_64
Reporter: Eric Waters
Assignee: Eric Waters
There are two more issues affecting the functioning of a Perl service server:
1. Failure to prepend the Perl namespace to the exception name when checking the exception type from a eval'ed method call.
2. writeMessageEnd() should be present after a method call writes its result.
I'm attaching a patch which addresses these issues, in addition to the following more minor changes:
1. Tried to make indentation and line breaks more consistent to ensure readability of the generated code.
2. Added a few best practice ideas to improve the code in minor ways.
3. Added a readAll() function to the Thrift::MemoryBuffer, as the one found in Thrift::Transport uses a while loop to consume the data, which results in a endless loop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-554) Perl improper namespace check for
exception handling and writeMessageEnd missing on processor calls
Posted by "Eric Waters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Waters updated THRIFT-554:
-------------------------------
Priority: Minor (was: Major)
> Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-554
> URL: https://issues.apache.org/jira/browse/THRIFT-554
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Environment: Ubuntu Jaunty x86_64
> Reporter: Eric Waters
> Assignee: Eric Waters
> Priority: Minor
> Attachments: thrift-554.diff
>
>
> There are two more issues affecting the functioning of a Perl service server:
> 1. Failure to prepend the Perl namespace to the exception name when checking the exception type from a eval'ed method call.
> 2. writeMessageEnd() should be present after a method call writes its result.
> I'm attaching a patch which addresses these issues, in addition to the following more minor changes:
> 1. Tried to make indentation and line breaks more consistent to ensure readability of the generated code.
> 2. Added a few best practice ideas to improve the code in minor ways.
> 3. Added a readAll() function to the Thrift::MemoryBuffer, as the one found in Thrift::Transport uses a while loop to consume the data, which results in a endless loop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-554) Perl improper namespace check for
exception handling and writeMessageEnd missing on processor calls
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani resolved THRIFT-554.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.2
Commited thx.
> Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-554
> URL: https://issues.apache.org/jira/browse/THRIFT-554
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Environment: Ubuntu Jaunty x86_64
> Reporter: Eric Waters
> Assignee: Eric Waters
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-554.diff
>
>
> There are two more issues affecting the functioning of a Perl service server:
> 1. Failure to prepend the Perl namespace to the exception name when checking the exception type from a eval'ed method call.
> 2. writeMessageEnd() should be present after a method call writes its result.
> I'm attaching a patch which addresses these issues, in addition to the following more minor changes:
> 1. Tried to make indentation and line breaks more consistent to ensure readability of the generated code.
> 2. Added a few best practice ideas to improve the code in minor ways.
> 3. Added a readAll() function to the Thrift::MemoryBuffer, as the one found in Thrift::Transport uses a while loop to consume the data, which results in a endless loop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-554) Perl improper namespace check for
exception handling and writeMessageEnd missing on processor calls
Posted by "Eric Waters (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Waters updated THRIFT-554:
-------------------------------
Attachment: thrift-554.diff
> Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-554
> URL: https://issues.apache.org/jira/browse/THRIFT-554
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Environment: Ubuntu Jaunty x86_64
> Reporter: Eric Waters
> Assignee: Eric Waters
> Attachments: thrift-554.diff
>
>
> There are two more issues affecting the functioning of a Perl service server:
> 1. Failure to prepend the Perl namespace to the exception name when checking the exception type from a eval'ed method call.
> 2. writeMessageEnd() should be present after a method call writes its result.
> I'm attaching a patch which addresses these issues, in addition to the following more minor changes:
> 1. Tried to make indentation and line breaks more consistent to ensure readability of the generated code.
> 2. Added a few best practice ideas to improve the code in minor ways.
> 3. Added a readAll() function to the Thrift::MemoryBuffer, as the one found in Thrift::Transport uses a while loop to consume the data, which results in a endless loop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-554) Perl improper namespace
check for exception handling and writeMessageEnd missing on processor calls
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737389#action_12737389 ]
T Jake Luciani edited comment on THRIFT-554 at 7/30/09 6:32 PM:
----------------------------------------------------------------
Committed thx.
was (Author: tjake):
Commited thx.
> Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-554
> URL: https://issues.apache.org/jira/browse/THRIFT-554
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Environment: Ubuntu Jaunty x86_64
> Reporter: Eric Waters
> Assignee: Eric Waters
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-554.diff
>
>
> There are two more issues affecting the functioning of a Perl service server:
> 1. Failure to prepend the Perl namespace to the exception name when checking the exception type from a eval'ed method call.
> 2. writeMessageEnd() should be present after a method call writes its result.
> I'm attaching a patch which addresses these issues, in addition to the following more minor changes:
> 1. Tried to make indentation and line breaks more consistent to ensure readability of the generated code.
> 2. Added a few best practice ideas to improve the code in minor ways.
> 3. Added a readAll() function to the Thrift::MemoryBuffer, as the one found in Thrift::Transport uses a while loop to consume the data, which results in a endless loop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-554) Perl improper namespace check for
exception handling and writeMessageEnd missing on processor calls
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908091#action_12908091 ]
David Reiss commented on THRIFT-554:
------------------------------------
Note that r982825 was committed with a tag of "THRIFT-554", but it was really for THRIFT-544.
> Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-554
> URL: https://issues.apache.org/jira/browse/THRIFT-554
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Compiler
> Environment: Ubuntu Jaunty x86_64
> Reporter: Eric Waters
> Assignee: Eric Waters
> Priority: Minor
> Fix For: 0.2
>
> Attachments: thrift-554.diff
>
>
> There are two more issues affecting the functioning of a Perl service server:
> 1. Failure to prepend the Perl namespace to the exception name when checking the exception type from a eval'ed method call.
> 2. writeMessageEnd() should be present after a method call writes its result.
> I'm attaching a patch which addresses these issues, in addition to the following more minor changes:
> 1. Tried to make indentation and line breaks more consistent to ensure readability of the generated code.
> 2. Added a few best practice ideas to improve the code in minor ways.
> 3. Added a readAll() function to the Thrift::MemoryBuffer, as the one found in Thrift::Transport uses a while loop to consume the data, which results in a endless loop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.