You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2023/07/24 10:17:19 UTC
[tomcat] branch 9.0.x updated (e179752441 -> 6aef3250f9)
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from e179752441 Fix use of incorrect constant
new d2e0ef68de StandardSession.java @doWriteObject: adds null-check to sessionPrincipal before checking if serializable to prevent misleading warning message logged.
new 6aef3250f9 Add an entry for BZ 66680 / #638
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
java/org/apache/catalina/session/StandardSession.java | 2 +-
webapps/docs/changelog.xml | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 02/02: Add an entry for BZ 66680 / #638
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 6aef3250f940fb41876bb4388b2cc0ad48093ec9
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Jul 24 11:14:52 2023 +0100
Add an entry for BZ 66680 / #638
https://bz.apache.org/bugzilla/show_bug.cgi?id=66680
---
webapps/docs/changelog.xml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 166b05ca7f..14f12ac999 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -119,6 +119,11 @@
Fix failure trying to persist configuration for an internal credential
handler. (remm)
</fix>
+ <fix>
+ <bug>66680</bug>: When serializing a session during the session
+ presistence process, do not log a warning that null Principals are not
+ serializable. Pull request <pr>638</pr> provided by tsryo. (markt)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 01/02: StandardSession.java @doWriteObject: adds null-check to sessionPrincipal before checking if serializable to prevent misleading warning message logged.
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit d2e0ef68de5408572fdb9885b2a0be5458525613
Author: Yordanov <ty...@amc.intra>
AuthorDate: Thu Jul 13 12:04:25 2023 +0200
StandardSession.java @doWriteObject: adds null-check to sessionPrincipal before checking if serializable to prevent misleading warning message logged.
---
java/org/apache/catalina/session/StandardSession.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/session/StandardSession.java b/java/org/apache/catalina/session/StandardSession.java
index f6c529a20c..5e1f463da8 100644
--- a/java/org/apache/catalina/session/StandardSession.java
+++ b/java/org/apache/catalina/session/StandardSession.java
@@ -1602,7 +1602,7 @@ public class StandardSession implements HttpSession, Session, Serializable {
if (getPersistAuthentication()) {
sessionAuthType = getAuthType();
sessionPrincipal = getPrincipal();
- if (!(sessionPrincipal instanceof Serializable)) {
+ if (sessionPrincipal != null && !(sessionPrincipal instanceof Serializable)) {
sessionPrincipal = null;
manager.getContext().getLogger().warn(sm.getString("standardSession.principalNotSerializable", id));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org