[GitHub] [superset] betodealmeida commented on a change in pull request #16037: fix: DB exported with incorrect type

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #16037:
URL: https://github.com/apache/superset/pull/16037#discussion_r681307321



##########
File path: superset/databases/schemas.py
##########
@@ -552,6 +552,25 @@ class DatabaseFunctionNamesResponse(Schema):
 
 
 class ImportV1DatabaseExtraSchema(Schema):
+    # pylint: disable=no-self-use, unused-argument
+    @pre_load
+    def fix_schemas_allowed_for_csv_upload(
+        self, data: Dict[str, Any], **kwargs: Any
+    ) -> Dict[str, Any]:
+        """
+        Fix ``schemas_allowed_for_csv_upload`` being a string.

Review comment:
       For sure! But I'm planning to work on a separate PR that fixes `schemas_allowed_for_csv_upload` being stored incorrectly, I thought of doing the migration there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org