You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "nadment (via GitHub)" <gi...@apache.org> on 2026/07/21 12:16:31 UTC
[PR] Remove the need to call the PropsUi.setLook() #2638 (hop)
nadment opened a new pull request, #7592:
URL: https://github.com/apache/hop/pull/7592
It's currently a proof of concept, but it works well on Windows (39 calls to setTheme vs. 8,000 calls to setLook).
However, we need to remember to use setTheme() for a control that changes dynamically. I think I've updated many places, but we might still find others.
Calls to the PropsUi.setLook() function haven't been removed yet, but these functions no longer do anything.
I'd like some help understanding how this works on other operating systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the need to call the PropsUi.setLook() #2638 (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment closed pull request #7592: Remove the need to call the PropsUi.setLook() #2638
URL: https://github.com/apache/hop/pull/7592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the need to call the PropsUi.setLook() #2638 (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on PR #7592:
URL: https://github.com/apache/hop/pull/7592#issuecomment-6176379791
I've put that aside for now; it's just a bonus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the need to call the PropsUi.setLook() #2638 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7592:
URL: https://github.com/apache/hop/pull/7592#issuecomment-6171409764
There's no rush. Let's do this in 2.21.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the need to call the PropsUi.setLook() #2638 (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7592:
URL: https://github.com/apache/hop/pull/7592#issuecomment-5057416994
Could you check the font where we want fixed width like JavaScript, SQL, and so on?
Other than that it looks fine on Linux.
<img width="2072" height="1115" alt="image" src="https://github.com/user-attachments/assets/b965a987-3b81-4957-893f-4b51cb15e4d1" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org