You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org> on 2009/09/18 00:53:57 UTC
[jira] Created: (MYFACES-2356) HtmlRadioRendererBase calls
converter method getAsString() not with the object, but with the string
version when an validation error occured
HtmlRadioRendererBase calls converter method getAsString() not with the object, but with the string version when an validation error occured
--------------------------------------------------------------------------------------------------------------------------------------------
Key: MYFACES-2356
URL: https://issues.apache.org/jira/browse/MYFACES-2356
Project: MyFaces Core
Issue Type: Bug
Components: General
Reporter: Jakob Korherr
Priority: Minor
If you have a <h:selectOneRadio> component with some SelectItems and you select an item, submit it and an validation error occurs, HtmlRadioRendererBase calls org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedStringValue() with the submitted value, which is not converted an therefore already the string version of the SelectItem. So the provided converter tries to convert the string version to the string version, which can end in strange behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2356) HtmlRadioRendererBase calls
converter method getAsString() not with the object, but with the string
version when an validation error occured
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr updated MYFACES-2356:
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-alpha-2
Status: Resolved (was: Patch Available)
Committed my patch.
> HtmlRadioRendererBase calls converter method getAsString() not with the object, but with the string version when an validation error occured
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2356
> URL: https://issues.apache.org/jira/browse/MYFACES-2356
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Priority: Minor
> Fix For: 2.0.0-alpha-2
>
> Attachments: HtmlRadioRendererBase.patch
>
>
> If you have a <h:selectOneRadio> component with some SelectItems and you select an item, submit it and an validation error occurs, HtmlRadioRendererBase calls org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedStringValue() with the submitted value, which is not converted an therefore already the string version of the SelectItem. So the provided converter tries to convert the string version to the string version, which can end in strange behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2356) HtmlRadioRendererBase calls
converter method getAsString() not with the object, but with the string
version when an validation error occured
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804956#action_12804956 ]
Jakob Korherr commented on MYFACES-2356:
----------------------------------------
I'm sorry that I don't have time to test this right now (I'm a little busy with university stuff), but please also check the behavior of UISelectMany components before the release, because they also use most of this code!
> HtmlRadioRendererBase calls converter method getAsString() not with the object, but with the string version when an validation error occured
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2356
> URL: https://issues.apache.org/jira/browse/MYFACES-2356
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Priority: Minor
> Fix For: 2.0.0-beta
>
> Attachments: HtmlRadioRendererBase.patch, MYFACES-2356-2.patch, MYFACES-2356-3.patch
>
>
> If you have a <h:selectOneRadio> component with some SelectItems and you select an item, submit it and an validation error occurs, HtmlRadioRendererBase calls org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedStringValue() with the submitted value, which is not converted an therefore already the string version of the SelectItem. So the provided converter tries to convert the string version to the string version, which can end in strange behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2356) HtmlRadioRendererBase calls
converter method getAsString() not with the object, but with the string
version when an validation error occured
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804907#action_12804907 ]
Leonardo Uribe commented on MYFACES-2356:
-----------------------------------------
Attached there is a patch implementing the new line added on renderkitdocs. Michael, could you confirm if this patch works as expected?
> HtmlRadioRendererBase calls converter method getAsString() not with the object, but with the string version when an validation error occured
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2356
> URL: https://issues.apache.org/jira/browse/MYFACES-2356
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Priority: Minor
> Fix For: 2.0.0-beta
>
> Attachments: HtmlRadioRendererBase.patch, MYFACES-2356-2.patch, MYFACES-2356-3.patch
>
>
> If you have a <h:selectOneRadio> component with some SelectItems and you select an item, submit it and an validation error occurs, HtmlRadioRendererBase calls org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedStringValue() with the submitted value, which is not converted an therefore already the string version of the SelectItem. So the provided converter tries to convert the string version to the string version, which can end in strange behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2356) HtmlRadioRendererBase calls
converter method getAsString() not with the object, but with the string
version when an validation error occured
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr updated MYFACES-2356:
-----------------------------------
Status: Patch Available (was: Open)
> HtmlRadioRendererBase calls converter method getAsString() not with the object, but with the string version when an validation error occured
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2356
> URL: https://issues.apache.org/jira/browse/MYFACES-2356
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Reporter: Jakob Korherr
> Priority: Minor
> Attachments: HtmlRadioRendererBase.patch
>
>
> If you have a <h:selectOneRadio> component with some SelectItems and you select an item, submit it and an validation error occurs, HtmlRadioRendererBase calls org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedStringValue() with the submitted value, which is not converted an therefore already the string version of the SelectItem. So the provided converter tries to convert the string version to the string version, which can end in strange behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2356) HtmlRadioRendererBase calls
converter method getAsString() not with the object, but with the string
version when an validation error occured
Posted by "Michael Kurz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804969#action_12804969 ]
Michael Kurz commented on MYFACES-2356:
---------------------------------------
Hi Leonardo, patch MYFACES-2356-3 works for me without problems. We could probably completely remove RendererUtils.NOTHING but preferably not before the beta release as this should not have any impact. I will create another issue and a patch.
> HtmlRadioRendererBase calls converter method getAsString() not with the object, but with the string version when an validation error occured
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-2356
> URL: https://issues.apache.org/jira/browse/MYFACES-2356
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Priority: Minor
> Fix For: 2.0.0-beta
>
> Attachments: HtmlRadioRendererBase.patch, MYFACES-2356-2.patch, MYFACES-2356-3.patch
>
>
> If you have a <h:selectOneRadio> component with some SelectItems and you select an item, submit it and an validation error occurs, HtmlRadioRendererBase calls org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedStringValue() with the submitted value, which is not converted an therefore already the string version of the SelectItem. So the provided converter tries to convert the string version to the string version, which can end in strange behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.