You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by DivineEnder <gi...@git.apache.org> on 2017/06/26 19:30:41 UTC
[GitHub] geode pull request #603: GEODE-3128: Changed the batch size to 1000 when cre...
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/603
GEODE-3128: Changed the batch size to 1000 when creating AEQFactory
* Prevously the batch size was the default 100
* Also added Lucene index overhead tests as performance tests. Currently these tests are ignored because they do not contain an assertions
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-3128
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/603.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #603
----
commit d51d650b494b60ffd6a4578c6fc7be3d76ffd705
Author: David Anuta <da...@gmail.com>
Date: 2017-06-19T15:55:34Z
GEODE-3128: Changed the batch size to 1000 when creating AEQFactory
* Prevously the batch size was the default 100
* Also added Lucene index overhead tests as performance tests. Currently these tests are ignored because they do not contain an assertions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #603: GEODE-3128: Changed the batch size to 1000 when creating A...
Posted by DivineEnder <gi...@git.apache.org>.
Github user DivineEnder commented on the issue:
https://github.com/apache/geode/pull/603
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #603: GEODE-3128: Changed the batch size to 1000 when cre...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/603#discussion_r125094490
--- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java ---
@@ -59,7 +64,7 @@
@Rule
public ExpectedException thrown = ExpectedException.none();
private static final String INDEX_NAME = "index";
- protected static final String REGION_NAME = "index";
+ public static final String REGION_NAME = "index";
--- End diff --
I don't think this needed to be made public - I think maybe the new test is importing the wrong static REGION_NAME?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #603: GEODE-3128: Changed the batch size to 1000 when creating A...
Posted by PurelyApplied <gi...@git.apache.org>.
Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/603
If you are using IntelliJ as your IDE and have not already done so, please remember to update your style file to that located in `geode/etc/intellij-java-modified-google-style.xml` to be consistent with Geode's established style guide. This file was updated June 13 with commit `a561bd12` to be consistent with documented expectations.
After having done so, please optimize the imports to the correct order of imports in `geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystem.java`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #603: GEODE-3128: Changed the batch size to 1000 when cre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/603
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---