You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2026/04/02 01:07:22 UTC

[PR] Remove Groovy v1-v2 checker, replace with v2-only DSL script execution tests [skywalking]

wu-sheng opened a new pull request, #13782:
URL: https://github.com/apache/skywalking/pull/13782

   ### Remove Groovy v1-v2 checker modules and replace with v2-only DSL script execution tests
   
   Now that 10.4.0 shipped with the v2 DSL engine and Groovy v1 is removed, the v1-v2 comparison
   checker is no longer needed. This PR replaces it with v2-only execution tests that validate
   all production DSL scripts against their companion `.data.yaml` test data.
   
   **Changes:**
   - Delete `test/script-cases/` entirely (scripts moved into analyzer modules, checker removed)
   - Move hierarchy tests + scripts into `oap-server/analyzer/hierarchy/` (no FQCN isolation needed)
   - Move LAL tests + scripts into `oap-server/analyzer/log-analyzer/` (no FQCN isolation needed)
   - Create `oap-server/analyzer/meter-analyzer-scripts-test/` for MAL tests (needs `ProcessRegistry` FQCN stub for mock isolation)
   - Fix `MalRuleLoader.formatExp()` bug — was dropping method chain after the first dot
   - Fix checkstyle JMH exclusion patterns (`jmh_generated` not `generated`)
   
   **Test counts (matching checker):**
   - MAL: 1268 expression + 31 filter = 1299
   - LAL: 37
   - Hierarchy: 22
   - Total: 1358, all pass
   
   - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove Groovy v1-v2 checker, move DSL script tests into analyzer modules [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #13782:
URL: https://github.com/apache/skywalking/pull/13782


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org