[jira] [Commented] (LUCENE-10475) Reconsider package structure in kuromoji and nori to mininize classes' visibiilty

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514045#comment-17514045 ] 

ASF subversion and git services commented on LUCENE-10475:
----------------------------------------------------------

Commit 2a3e5ca07f5df1f5080b5cb54ff104b7924e99f3 in lucene's branch refs/heads/main from Tomoko Uchida
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=2a3e5ca ]

LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict (#772)



> Reconsider package structure in kuromoji and nori to mininize classes' visibiilty
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-10475
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10475
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Tomoko Uchida
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Some internal dictionary classes in `.dict` package are exposed to public in order to share their constants with dictionary writers that are reside in a separate package `.util`.
> `.util` actually has only dictionary writers/builders, it would make sense to merge all classes `.util` to `.dict` so that we can make the internals package-private.
> The change was suggested/discussed in [https://github.com/apache/lucene/pull/740].



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org