You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/05 18:25:23 UTC
[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14637
Change subject: [thirdparty] add license info about yaml-cpp and chrony
......................................................................
[thirdparty] add license info about yaml-cpp and chrony
Added license information on yaml-cpp and chrony (build/test-only
dependency) into thirdparty/LICENSE.txt.
This patch doesn't have any functional modifications.
Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
---
M thirdparty/LICENSE.txt
1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/14637/1
--
To view, visit http://gerrit.cloudera.org:8080/14637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14637
to look at the new patch set (#2).
Change subject: [thirdparty] add license info about yaml-cpp and chrony
......................................................................
[thirdparty] add license info about yaml-cpp and chrony
Added license information on yaml-cpp and chrony (build/test-only
dependency) into thirdparty/LICENSE.txt.
This patch doesn't have any functional modifications.
Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
---
M thirdparty/LICENSE.txt
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/14637/2
--
To view, visit http://gerrit.cloudera.org:8080/14637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14637 )
Change subject: [thirdparty] add license info about yaml-cpp and chrony
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14637/2/thirdparty/LICENSE.txt
File thirdparty/LICENSE.txt:
http://gerrit.cloudera.org:8080/#/c/14637/2/thirdparty/LICENSE.txt@689
PS2, Line 689: 3.5
> Nit: should be '*' so that it's not technically incorrect if/when we update
Good catch. I was thinking to put the asterisk there (as in other entries in this file), but ended up with exact path for some reason.
Fixed.
--
To view, visit http://gerrit.cloudera.org:8080/14637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 13:10:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14637 )
Change subject: [thirdparty] add license info about yaml-cpp and chrony
......................................................................
Patch Set 3: Code-Review+2
Carrying over Adar's +2 from PS2.
--
To view, visit http://gerrit.cloudera.org:8080/14637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 14:50:08 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14637 )
Change subject: [thirdparty] add license info about yaml-cpp and chrony
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14637/2/thirdparty/LICENSE.txt
File thirdparty/LICENSE.txt:
http://gerrit.cloudera.org:8080/#/c/14637/2/thirdparty/LICENSE.txt@689
PS2, Line 689: 3.5
Nit: should be '*' so that it's not technically incorrect if/when we update the version.
--
To view, visit http://gerrit.cloudera.org:8080/14637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 08:10:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14637
to look at the new patch set (#3).
Change subject: [thirdparty] add license info about yaml-cpp and chrony
......................................................................
[thirdparty] add license info about yaml-cpp and chrony
Added license information on yaml-cpp and chrony (build/test-only
dependency) into thirdparty/LICENSE.txt.
This patch doesn't have any functional modifications.
Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
---
M thirdparty/LICENSE.txt
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/14637/3
--
To view, visit http://gerrit.cloudera.org:8080/14637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14637 )
Change subject: [thirdparty] add license info about yaml-cpp and chrony
......................................................................
[thirdparty] add license info about yaml-cpp and chrony
Added license information on yaml-cpp and chrony (build/test-only
dependency) into thirdparty/LICENSE.txt.
This patch doesn't have any functional modifications.
Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Reviewed-on: http://gerrit.cloudera.org:8080/14637
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/LICENSE.txt
1 file changed, 30 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>