You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/02 09:21:53 UTC
[GitHub] [apisix] starsz commented on a diff in pull request #7822: feat: Add ability to inject headers via prefix to otel traces
starsz commented on code in PR #7822:
URL: https://github.com/apache/apisix/pull/7822#discussion_r961476691
##########
docs/en/latest/plugins/opentelemetry.md:
##########
@@ -46,6 +46,8 @@ The Plugin only supports binary-encoded [OLTP over HTTP](https://opentelemetry.i
| sampler.options.root.options.fraction | number | False | 0 | [0, 1] | Root sampling probability for `trace_id_ratio`. |
| additional_attributes | array[string] | False | | | Variables and its values which will be appended to the trace span. |
| additional_attributes[0] | string | True | | | APISIX or Nginx variables. For example, `http_header` or `route_id`. |
+| additional_header_attributes | array[string] | False | | | Variables and its values which will be appended to the trace span. |
+| additional_header_attributes[0] | string | True | | | Request headers. For example, `x-my-header"` or `x-my-headers-*` to include all headers with the prefix `x-my-headers-`. |
Review Comment:
```suggestion
| additional_header_attributes[0] | string | True | | | Request headers. For example, `x-my-header` or `x-my-headers-*` to include all headers with the prefix `x-my-headers-`. |
```
Haha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org