You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/06/29 19:26:27 UTC
Change in asterixdb[mad-hatter]: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
From Michael Blow <mb...@apache.org>:
Hello Glenn Galvizo,
I'd like you to do a code review. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
to review the following change.
Change subject: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
......................................................................
[NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
- user mode changes: no
- storage format changes: no
- interface changes: no
Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12003
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@uci.edu>
Contrib: Ian Maxon <im...@uci.edu>
(cherry picked from commit 86c18127feda4b189bec024f6c8502e7e6436bf3)
---
M asterixdb/asterix-dashboard/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/12123/1
diff --git a/asterixdb/asterix-dashboard/pom.xml b/asterixdb/asterix-dashboard/pom.xml
index 75fb8d2..38f962a 100644
--- a/asterixdb/asterix-dashboard/pom.xml
+++ b/asterixdb/asterix-dashboard/pom.xml
@@ -66,7 +66,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
- <version>1.6</version>
+ <version>1.11.0</version>
<configuration>
<nodeVersion>v10.3.0</nodeVersion>
<npmVersion>6.1.0</npmVersion>
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Gerrit-Change-Number: 12123
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Glenn Galvizo <gg...@uci.edu>
Gerrit-MessageType: newchange
Change in asterixdb[mad-hatter]: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Jenkins <je...@fulliautomatix.ics.uci.edu>:
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123 )
Change subject: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/12149/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Gerrit-Change-Number: 12123
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Glenn Galvizo <gg...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Tue, 29 Jun 2021 20:30:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[mad-hatter]: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Hello Glenn Galvizo,
I'd like you to do a code review. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
to review the following change.
Change subject: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
......................................................................
[NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
- user mode changes: no
- storage format changes: no
- interface changes: no
Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12003
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@uci.edu>
Contrib: Ian Maxon <im...@uci.edu>
(cherry picked from commit 86c18127feda4b189bec024f6c8502e7e6436bf3)
---
M asterixdb/asterix-dashboard/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/12123/1
diff --git a/asterixdb/asterix-dashboard/pom.xml b/asterixdb/asterix-dashboard/pom.xml
index 75fb8d2..38f962a 100644
--- a/asterixdb/asterix-dashboard/pom.xml
+++ b/asterixdb/asterix-dashboard/pom.xml
@@ -66,7 +66,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
- <version>1.6</version>
+ <version>1.11.0</version>
<configuration>
<nodeVersion>v10.3.0</nodeVersion>
<npmVersion>6.1.0</npmVersion>
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Gerrit-Change-Number: 12123
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Glenn Galvizo <gg...@uci.edu>
Gerrit-MessageType: newchange
Change in asterixdb[mad-hatter]: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123 )
Change subject: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
......................................................................
Patch Set 1: Contrib-2
Analytics Compatibility Tests Failed
https://cbjenkins.page.link/P1TQUZegzze17fGm9 : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Gerrit-Change-Number: 12123
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo <gg...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Tue, 29 Jun 2021 21:19:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[mad-hatter]: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Glenn Galvizo <gg...@uci.edu>:
Glenn Galvizo has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123 )
Change subject: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Gerrit-Change-Number: 12123
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo <gg...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Tue, 29 Jun 2021 23:48:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[mad-hatter]: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123 )
Change subject: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/DH8Fpvci5BWfi4126 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Gerrit-Change-Number: 12123
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Glenn Galvizo <gg...@uci.edu>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Tue, 29 Jun 2021 19:33:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[mad-hatter]: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123 )
Change subject: [NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
......................................................................
[NO-ISSUE][MVN] Plugin update (to build on M1 macbooks).
- user mode changes: no
- storage format changes: no
- interface changes: no
Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12003
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@uci.edu>
Contrib: Ian Maxon <im...@uci.edu>
(cherry picked from commit 86c18127feda4b189bec024f6c8502e7e6436bf3)
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
Reviewed-by: Glenn Galvizo <gg...@uci.edu>
---
M asterixdb/asterix-dashboard/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Glenn Galvizo: Looks good to me, approved
Jenkins: Verified; Verified
Objections:
Anon. E. Moose #1000171: Violations found
diff --git a/asterixdb/asterix-dashboard/pom.xml b/asterixdb/asterix-dashboard/pom.xml
index 75fb8d2..38f962a 100644
--- a/asterixdb/asterix-dashboard/pom.xml
+++ b/asterixdb/asterix-dashboard/pom.xml
@@ -66,7 +66,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
- <version>1.6</version>
+ <version>1.11.0</version>
<configuration>
<nodeVersion>v10.3.0</nodeVersion>
<npmVersion>6.1.0</npmVersion>
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12123
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: mad-hatter
Gerrit-Change-Id: Ie947924ddff4da62c5e95f6a93ad827550a6fe67
Gerrit-Change-Number: 12123
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo <gg...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-MessageType: merged