[GitHub] [activemq-artemis] gemmellr commented on issue #2634: ARTEMIS-2316 AMQPMessage missing ApplicationProperties from custom transformer

[GitBox <gi...@apache.org>]

gemmellr commented on issue #2634: ARTEMIS-2316 AMQPMessage missing ApplicationProperties from custom transformer
URL: https://github.com/apache/activemq-artemis/pull/2634#issuecomment-486280022
 
 
   This feels like it might be the wrong change.
   
   To my knowledge the reencode method is expected to be used explicitly in cases like this, and thats actually the main reason it exists at all and was added originally.
   
   The commit pointed to as the earlier change in behaviour for 2.6.4 was clearly the correct change to make for that issue, if anything it would seem the original behaviour was incorrect/unexpected. Changing 2.8.0 to differ from 2.7.0 and 2.6.4 (doing whats expected) just to restore a 2.6.3 behaviour that perhaps shouldn't have been there isnt seeming all that obvious to me. It would also now become inconsistent amongst itself regarding what happens with other modifications to the message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services