[GitHub] [iceberg] chenjunjiedada commented on a change in pull request #1955: Spark: Sort retained rows in DELETE FROM by file and position

[GitBox <gi...@apache.org>]

chenjunjiedada commented on a change in pull request #1955:
URL: https://github.com/apache/iceberg/pull/1955#discussion_r546184999



##########
File path: arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -381,9 +382,13 @@ public VectorHolder read(VectorHolder reuse, int numValsToRead) {
         for (int i = 0; i < numValsToRead; i += 1) {
           vec.getDataBuffer().setLong(i * Long.BYTES, rowStart + i);
         }
+        for (int i = 0; i < numValsToRead; i += 1) {
+          BitVectorHelper.setValidityBitToOne(vec.getValidityBuffer(), i);
+        }
         nulls = new NullabilityHolder(numValsToRead);
       }
 
+      rowStart += numValsToRead;

Review comment:
       Great catch! Let me update the unit test as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org