You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Enrico Olivelli <eo...@gmail.com> on 2021/06/15 10:36:38 UTC
Problems in upgrading ZooKeeper to 3.6.3
Hello,
During the past weeks I have been trying to upgrade ZK dependency to 3.7.0.
But I had test failures.
Today I tried to upgrade from 3.6.0 to 3.6.1, 3.6.2 and 3.6.3.
and I discovered that the failures reproduce on 3.6.3 as well as in 3.7.x.
The error is below, is org.apache.curator.framework.imps.TestFrameworkEdges
I will continue to investigate, but probably this is something to
resolve before cutting the new release.
I really would like to cut a release soon
Enrico
[ERROR] Errors:
[ERROR] org.apache.curator.framework.imps.TestFrameworkEdges.testFailure
[ERROR] Run 1: TestFrameworkEdges.testFailure:670 » SessionExpired
KeeperErrorCode = Session ...
[ERROR] Run 2: TestFrameworkEdges.testFailure:670 » SessionExpired
KeeperErrorCode = Session ...
[ERROR] Run 3: TestFrameworkEdges.testFailure:670 » SessionExpired
KeeperErrorCode = Session ...
Re: Problems in upgrading ZooKeeper to 3.6.3
Posted by Enrico Olivelli <eo...@gmail.com>.
I have merged the upgrade to ZK 3.6.3.
Thank you Tison and Cameron
Enrico
Il giorno lun 5 lug 2021 alle ore 13:54 Enrico Olivelli <eo...@gmail.com>
ha scritto:
>
>
> Il giorno mar 29 giu 2021 alle ore 00:43 Cameron McKenzie <
> mckenzie.cam@gmail.com> ha scritto:
>
>> hey Enrico,
>> For me the tests are only failing in curator-test-zk35. Is that the same
>> for you?
>>
>
> yes.
> I fixed the problem
>
> There is a behaviour change with the upgrade to ZK 3.6.3.
> see here
>
> https://github.com/apache/curator/pull/386/files#diff-759b48d71f3ba7e38000f866b256b62bb300525c456be688b63a0bb3c575d12bR673
>
> basically we get a SessionExpired error instead of a ConnectionLoss
>
> I believe it is not a problem in Curator and we have to live with this new
> behaviour in the test.
> The same problem is on ZK 3.7.x
>
> I cannot find any relevant change in 3.6.3 release notes
> https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html
>
> If there are no objections I would push the update and then start the
> release process
>
> Enrico
>
>
>
>> cheers
>>
>> On Mon, Jun 28, 2021 at 9:14 PM Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>> > Sorry for late reply
>> >
>> > This is my PR
>> > https://github.com/apache/curator/pull/386
>> >
>> > Once we can upgrade to 3.6.3 I can move forward with the upgrade to
>> 3.7.0.
>> >
>> > I had to fix ZooKeeperEmbedded in ZooKeeper, so the fix will be
>> available
>> > only in 3.7.1.
>> >
>> > The best move for us currently IMHO is to upgrade to 3.6.3 and cut a
>> > release ASAP
>> >
>> > Enrico
>> >
>> > Il giorno mar 15 giu 2021 alle ore 23:41 Cameron McKenzie <
>> > mckenzie.cam@gmail.com> ha scritto:
>> >
>> > > hey Enrico,
>> > > Do you have a branch in the Curator git repo with the changes?
>> > > cheers
>> > >
>> > > On Tue, Jun 15, 2021 at 8:36 PM Enrico Olivelli <eo...@gmail.com>
>> > > wrote:
>> > >
>> > > > Hello,
>> > > > During the past weeks I have been trying to upgrade ZK dependency to
>> > > 3.7.0.
>> > > > But I had test failures.
>> > > >
>> > > > Today I tried to upgrade from 3.6.0 to 3.6.1, 3.6.2 and 3.6.3.
>> > > > and I discovered that the failures reproduce on 3.6.3 as well as in
>> > > 3.7.x.
>> > > >
>> > > > The error is below, is
>> > > org.apache.curator.framework.imps.TestFrameworkEdges
>> > > >
>> > > > I will continue to investigate, but probably this is something to
>> > > > resolve before cutting the new release.
>> > > >
>> > > > I really would like to cut a release soon
>> > > >
>> > > > Enrico
>> > > >
>> > > > [ERROR] Errors:
>> > > > [ERROR]
>> > org.apache.curator.framework.imps.TestFrameworkEdges.testFailure
>> > > > [ERROR] Run 1: TestFrameworkEdges.testFailure:670 » SessionExpired
>> > > > KeeperErrorCode = Session ...
>> > > > [ERROR] Run 2: TestFrameworkEdges.testFailure:670 » SessionExpired
>> > > > KeeperErrorCode = Session ...
>> > > > [ERROR] Run 3: TestFrameworkEdges.testFailure:670 » SessionExpired
>> > > > KeeperErrorCode = Session ...
>> > > >
>> > >
>> >
>>
>
Re: Problems in upgrading ZooKeeper to 3.6.3
Posted by Enrico Olivelli <eo...@gmail.com>.
Il giorno mar 29 giu 2021 alle ore 00:43 Cameron McKenzie <
mckenzie.cam@gmail.com> ha scritto:
> hey Enrico,
> For me the tests are only failing in curator-test-zk35. Is that the same
> for you?
>
yes.
I fixed the problem
There is a behaviour change with the upgrade to ZK 3.6.3.
see here
https://github.com/apache/curator/pull/386/files#diff-759b48d71f3ba7e38000f866b256b62bb300525c456be688b63a0bb3c575d12bR673
basically we get a SessionExpired error instead of a ConnectionLoss
I believe it is not a problem in Curator and we have to live with this new
behaviour in the test.
The same problem is on ZK 3.7.x
I cannot find any relevant change in 3.6.3 release notes
https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html
If there are no objections I would push the update and then start the
release process
Enrico
> cheers
>
> On Mon, Jun 28, 2021 at 9:14 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Sorry for late reply
> >
> > This is my PR
> > https://github.com/apache/curator/pull/386
> >
> > Once we can upgrade to 3.6.3 I can move forward with the upgrade to
> 3.7.0.
> >
> > I had to fix ZooKeeperEmbedded in ZooKeeper, so the fix will be available
> > only in 3.7.1.
> >
> > The best move for us currently IMHO is to upgrade to 3.6.3 and cut a
> > release ASAP
> >
> > Enrico
> >
> > Il giorno mar 15 giu 2021 alle ore 23:41 Cameron McKenzie <
> > mckenzie.cam@gmail.com> ha scritto:
> >
> > > hey Enrico,
> > > Do you have a branch in the Curator git repo with the changes?
> > > cheers
> > >
> > > On Tue, Jun 15, 2021 at 8:36 PM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > > Hello,
> > > > During the past weeks I have been trying to upgrade ZK dependency to
> > > 3.7.0.
> > > > But I had test failures.
> > > >
> > > > Today I tried to upgrade from 3.6.0 to 3.6.1, 3.6.2 and 3.6.3.
> > > > and I discovered that the failures reproduce on 3.6.3 as well as in
> > > 3.7.x.
> > > >
> > > > The error is below, is
> > > org.apache.curator.framework.imps.TestFrameworkEdges
> > > >
> > > > I will continue to investigate, but probably this is something to
> > > > resolve before cutting the new release.
> > > >
> > > > I really would like to cut a release soon
> > > >
> > > > Enrico
> > > >
> > > > [ERROR] Errors:
> > > > [ERROR]
> > org.apache.curator.framework.imps.TestFrameworkEdges.testFailure
> > > > [ERROR] Run 1: TestFrameworkEdges.testFailure:670 » SessionExpired
> > > > KeeperErrorCode = Session ...
> > > > [ERROR] Run 2: TestFrameworkEdges.testFailure:670 » SessionExpired
> > > > KeeperErrorCode = Session ...
> > > > [ERROR] Run 3: TestFrameworkEdges.testFailure:670 » SessionExpired
> > > > KeeperErrorCode = Session ...
> > > >
> > >
> >
>
Re: Problems in upgrading ZooKeeper to 3.6.3
Posted by Cameron McKenzie <mc...@gmail.com>.
hey Enrico,
For me the tests are only failing in curator-test-zk35. Is that the same
for you?
cheers
On Mon, Jun 28, 2021 at 9:14 PM Enrico Olivelli <eo...@gmail.com> wrote:
> Sorry for late reply
>
> This is my PR
> https://github.com/apache/curator/pull/386
>
> Once we can upgrade to 3.6.3 I can move forward with the upgrade to 3.7.0.
>
> I had to fix ZooKeeperEmbedded in ZooKeeper, so the fix will be available
> only in 3.7.1.
>
> The best move for us currently IMHO is to upgrade to 3.6.3 and cut a
> release ASAP
>
> Enrico
>
> Il giorno mar 15 giu 2021 alle ore 23:41 Cameron McKenzie <
> mckenzie.cam@gmail.com> ha scritto:
>
> > hey Enrico,
> > Do you have a branch in the Curator git repo with the changes?
> > cheers
> >
> > On Tue, Jun 15, 2021 at 8:36 PM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Hello,
> > > During the past weeks I have been trying to upgrade ZK dependency to
> > 3.7.0.
> > > But I had test failures.
> > >
> > > Today I tried to upgrade from 3.6.0 to 3.6.1, 3.6.2 and 3.6.3.
> > > and I discovered that the failures reproduce on 3.6.3 as well as in
> > 3.7.x.
> > >
> > > The error is below, is
> > org.apache.curator.framework.imps.TestFrameworkEdges
> > >
> > > I will continue to investigate, but probably this is something to
> > > resolve before cutting the new release.
> > >
> > > I really would like to cut a release soon
> > >
> > > Enrico
> > >
> > > [ERROR] Errors:
> > > [ERROR]
> org.apache.curator.framework.imps.TestFrameworkEdges.testFailure
> > > [ERROR] Run 1: TestFrameworkEdges.testFailure:670 » SessionExpired
> > > KeeperErrorCode = Session ...
> > > [ERROR] Run 2: TestFrameworkEdges.testFailure:670 » SessionExpired
> > > KeeperErrorCode = Session ...
> > > [ERROR] Run 3: TestFrameworkEdges.testFailure:670 » SessionExpired
> > > KeeperErrorCode = Session ...
> > >
> >
>
Re: Problems in upgrading ZooKeeper to 3.6.3
Posted by Enrico Olivelli <eo...@gmail.com>.
Sorry for late reply
This is my PR
https://github.com/apache/curator/pull/386
Once we can upgrade to 3.6.3 I can move forward with the upgrade to 3.7.0.
I had to fix ZooKeeperEmbedded in ZooKeeper, so the fix will be available
only in 3.7.1.
The best move for us currently IMHO is to upgrade to 3.6.3 and cut a
release ASAP
Enrico
Il giorno mar 15 giu 2021 alle ore 23:41 Cameron McKenzie <
mckenzie.cam@gmail.com> ha scritto:
> hey Enrico,
> Do you have a branch in the Curator git repo with the changes?
> cheers
>
> On Tue, Jun 15, 2021 at 8:36 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Hello,
> > During the past weeks I have been trying to upgrade ZK dependency to
> 3.7.0.
> > But I had test failures.
> >
> > Today I tried to upgrade from 3.6.0 to 3.6.1, 3.6.2 and 3.6.3.
> > and I discovered that the failures reproduce on 3.6.3 as well as in
> 3.7.x.
> >
> > The error is below, is
> org.apache.curator.framework.imps.TestFrameworkEdges
> >
> > I will continue to investigate, but probably this is something to
> > resolve before cutting the new release.
> >
> > I really would like to cut a release soon
> >
> > Enrico
> >
> > [ERROR] Errors:
> > [ERROR] org.apache.curator.framework.imps.TestFrameworkEdges.testFailure
> > [ERROR] Run 1: TestFrameworkEdges.testFailure:670 » SessionExpired
> > KeeperErrorCode = Session ...
> > [ERROR] Run 2: TestFrameworkEdges.testFailure:670 » SessionExpired
> > KeeperErrorCode = Session ...
> > [ERROR] Run 3: TestFrameworkEdges.testFailure:670 » SessionExpired
> > KeeperErrorCode = Session ...
> >
>
Re: Problems in upgrading ZooKeeper to 3.6.3
Posted by Cameron McKenzie <mc...@gmail.com>.
hey Enrico,
Do you have a branch in the Curator git repo with the changes?
cheers
On Tue, Jun 15, 2021 at 8:36 PM Enrico Olivelli <eo...@gmail.com> wrote:
> Hello,
> During the past weeks I have been trying to upgrade ZK dependency to 3.7.0.
> But I had test failures.
>
> Today I tried to upgrade from 3.6.0 to 3.6.1, 3.6.2 and 3.6.3.
> and I discovered that the failures reproduce on 3.6.3 as well as in 3.7.x.
>
> The error is below, is org.apache.curator.framework.imps.TestFrameworkEdges
>
> I will continue to investigate, but probably this is something to
> resolve before cutting the new release.
>
> I really would like to cut a release soon
>
> Enrico
>
> [ERROR] Errors:
> [ERROR] org.apache.curator.framework.imps.TestFrameworkEdges.testFailure
> [ERROR] Run 1: TestFrameworkEdges.testFailure:670 » SessionExpired
> KeeperErrorCode = Session ...
> [ERROR] Run 2: TestFrameworkEdges.testFailure:670 » SessionExpired
> KeeperErrorCode = Session ...
> [ERROR] Run 3: TestFrameworkEdges.testFailure:670 » SessionExpired
> KeeperErrorCode = Session ...
>