You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/12/28 23:38:20 UTC

[Impala-ASF-CR] IMPALA-2536: Make ColumnType constructor explicit

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16906

to look at the new patch set (#2).

Change subject: IMPALA-2536: Make ColumnType constructor explicit
......................................................................

IMPALA-2536: Make ColumnType constructor explicit

This avoids accidental implicit type conversions from
the PrimitiveType enum, or worse, integer values via
the enum.

Testing:
Ran core tests.

Change-Id: I2fe1d5da051c10904605328607bea78565356ef3
---
M be/src/benchmarks/hash-benchmark.cc
M be/src/codegen/llvm-codegen-test.cc
M be/src/exec/grouping-aggregator.cc
M be/src/exec/hash-table-test.cc
M be/src/exec/hash-table.cc
M be/src/exec/hdfs-scanner.cc
M be/src/exprs/case-expr.cc
M be/src/exprs/compound-predicates.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/is-not-empty-predicate.cc
M be/src/exprs/null-literal.h
M be/src/exprs/valid-tuple-id.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/date-test.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/raw-value-test.cc
M be/src/runtime/row-batch-serialize-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/runtime/types.h
M be/src/service/hs2-util.cc
M be/src/testutil/desc-tbl-builder.h
M be/src/util/avro-util.cc
M be/src/util/symbols-util-test.cc
24 files changed, 244 insertions(+), 191 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/16906/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fe1d5da051c10904605328607bea78565356ef3
Gerrit-Change-Number: 16906
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>