You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/24 01:05:41 UTC
[GitHub] [beam] aaltay opened a new pull request #13187: Updated shared.py comments
aaltay opened a new pull request #13187:
URL: https://github.com/apache/beam/pull/13187
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #13187: Updated shared.py comments
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13187:
URL: https://github.com/apache/beam/pull/13187#issuecomment-726339038
that's been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on a change in pull request #13187: Updated shared.py comments
Posted by GitBox <gi...@apache.org>.
aaltay commented on a change in pull request #13187:
URL: https://github.com/apache/beam/pull/13187#discussion_r513113926
##########
File path: sdks/python/apache_beam/utils/shared.py
##########
@@ -26,22 +26,30 @@
To share a very large list across all threads of each worker in a DoFn::
- class GetNthStringFn(beam.DoFn):
- def __init__(self, shared_handle):
- self._shared_handle = shared_handle
-
- def process(self, element):
- def initialize_list():
- # Build the giant initial list.
- return [str(i) for i in range(1000000)]
-
- giant_list = self._shared_handle.acquire(initialize_list)
- yield giant_list[element]
-
- p = beam.Pipeline()
- shared_handle = shared.Shared()
- (p | beam.Create([2, 4, 6, 8])
- | beam.ParDo(GetNthStringFn(shared_handle)))
+# Several built-in types such as list and dict do not directly support weak
+# references but can add support through subclassing:
+# https://docs.python.org/3/library/weakref.html
+class WeakRefList(list):
+ pass
+
+class GetNthStringFn(beam.DoFn):
+ def __init__(self, shared_handle):
+ self._shared_handle = shared_handle
+
+ def setup(self):
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #13187: Updated shared.py comments
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13187:
URL: https://github.com/apache/beam/pull/13187#issuecomment-726272259
> @pabloem
>
> Tests are failing with pip check "17:56:38 botocore 1.19.16 has requirement urllib3<1.26,>=1.25.4; python_version != "3.4", but you have urllib3 1.26.1." Do you know if this is a flake?
no. this is breaking precommits and other PRs. I can investigate...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #13187: Updated shared.py comments
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #13187:
URL: https://github.com/apache/beam/pull/13187#issuecomment-726292405
https://github.com/apache/beam/pull/13321 is out to fix that precommit issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #13187: Updated shared.py comments
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #13187:
URL: https://github.com/apache/beam/pull/13187#issuecomment-726265987
@pabloem
Tests are failing with pip check "17:56:38 botocore 1.19.16 has requirement urllib3<1.26,>=1.25.4; python_version != "3.4", but you have urllib3 1.26.1." Do you know if this is a flake?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] rezarokni commented on a change in pull request #13187: Updated shared.py comments
Posted by GitBox <gi...@apache.org>.
rezarokni commented on a change in pull request #13187:
URL: https://github.com/apache/beam/pull/13187#discussion_r511690076
##########
File path: sdks/python/apache_beam/utils/shared.py
##########
@@ -26,22 +26,30 @@
To share a very large list across all threads of each worker in a DoFn::
- class GetNthStringFn(beam.DoFn):
- def __init__(self, shared_handle):
- self._shared_handle = shared_handle
-
- def process(self, element):
- def initialize_list():
- # Build the giant initial list.
- return [str(i) for i in range(1000000)]
-
- giant_list = self._shared_handle.acquire(initialize_list)
- yield giant_list[element]
-
- p = beam.Pipeline()
- shared_handle = shared.Shared()
- (p | beam.Create([2, 4, 6, 8])
- | beam.ParDo(GetNthStringFn(shared_handle)))
+# Several built-in types such as list and dict do not directly support weak
+# references but can add support through subclassing:
+# https://docs.python.org/3/library/weakref.html
+class WeakRefList(list):
+ pass
+
+class GetNthStringFn(beam.DoFn):
+ def __init__(self, shared_handle):
+ self._shared_handle = shared_handle
+
+ def setup(self):
Review comment:
Be good to have a note why setup is best place to do the init.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #13187: Updated shared.py comments
Posted by GitBox <gi...@apache.org>.
aaltay merged pull request #13187:
URL: https://github.com/apache/beam/pull/13187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #13187: Updated shared.py comments
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #13187:
URL: https://github.com/apache/beam/pull/13187#discussion_r513823318
##########
File path: sdks/python/apache_beam/utils/shared.py
##########
@@ -26,22 +26,31 @@
To share a very large list across all threads of each worker in a DoFn::
- class GetNthStringFn(beam.DoFn):
- def __init__(self, shared_handle):
- self._shared_handle = shared_handle
-
- def process(self, element):
- def initialize_list():
- # Build the giant initial list.
- return [str(i) for i in range(1000000)]
-
- giant_list = self._shared_handle.acquire(initialize_list)
- yield giant_list[element]
-
- p = beam.Pipeline()
- shared_handle = shared.Shared()
- (p | beam.Create([2, 4, 6, 8])
- | beam.ParDo(GetNthStringFn(shared_handle)))
+# Several built-in types such as list and dict do not directly support weak
Review comment:
Consider following wording for line 29 to prepare the reader for why weak references are discussed:
Shared is a helper class for managing a single instance of an object shared by multiple threads within the same process. Instances of Shared are serializable objects that can be shared by all threads of each worker process. A Shared object encapsulates a weak reference to a singleton instance of the shared resource. The singleton is lazily initialized by calls to Shared.acquire().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org