You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2014/05/27 23:54:00 UTC
git commit: [SPARK-1926] [SQL] Nullability of Max/Min/First should be
true.
Repository: spark
Updated Branches:
refs/heads/master 95e4c9c6f -> d1375a2bf
[SPARK-1926] [SQL] Nullability of Max/Min/First should be true.
Nullability of `Max`/`Min`/`First` should be `true` because they return `null` if there are no rows.
Author: Takuya UESHIN <ue...@happy-camper.st>
Closes #881 from ueshin/issues/SPARK-1926 and squashes the following commits:
322610f [Takuya UESHIN] Fix nullability of Min/Max/First.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/d1375a2b
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/d1375a2b
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/d1375a2b
Branch: refs/heads/master
Commit: d1375a2bff846f2c4274e14545924646852895f9
Parents: 95e4c9c
Author: Takuya UESHIN <ue...@happy-camper.st>
Authored: Tue May 27 14:53:57 2014 -0700
Committer: Reynold Xin <rx...@apache.org>
Committed: Tue May 27 14:53:57 2014 -0700
----------------------------------------------------------------------
.../org/apache/spark/sql/catalyst/expressions/aggregates.scala | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/d1375a2b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
index 79937b1..b49a461 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
@@ -90,7 +90,7 @@ abstract class AggregateFunction
case class Min(child: Expression) extends PartialAggregate with trees.UnaryNode[Expression] {
override def references = child.references
- override def nullable = child.nullable
+ override def nullable = true
override def dataType = child.dataType
override def toString = s"MIN($child)"
@@ -120,7 +120,7 @@ case class MinFunction(expr: Expression, base: AggregateExpression) extends Aggr
case class Max(child: Expression) extends PartialAggregate with trees.UnaryNode[Expression] {
override def references = child.references
- override def nullable = child.nullable
+ override def nullable = true
override def dataType = child.dataType
override def toString = s"MAX($child)"
@@ -257,7 +257,7 @@ case class SumDistinct(child: Expression)
case class First(child: Expression) extends PartialAggregate with trees.UnaryNode[Expression] {
override def references = child.references
- override def nullable = child.nullable
+ override def nullable = true
override def dataType = child.dataType
override def toString = s"FIRST($child)"