You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by dlmarion <gi...@git.apache.org> on 2016/03/31 15:18:27 UTC
[GitHub] accumulo pull request: Accumulo 4169 - context cleanup
GitHub user dlmarion opened a pull request:
https://github.com/apache/accumulo/pull/85
Accumulo 4169 - context cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/accumulo ACCUMULO-4169
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 0b2f28860817cc41fde48126b969de704cbd60d4
Author: Dave Marion <dl...@apache.org>
Date: 2016-03-29T17:27:07Z
ACCUMULO-4169: Remove contexts not defined in the configuration
Contexts can be defined and not configured for a table, which are then used on Scanners. By
cleaning up contexts not defined on tables, contexts could be closed while they are in use in
a scan session. Only clean up contexts that are not in the configuration.
commit 7a654ee0644815f7a0244d342333c75de667adb2
Author: Dave Marion <dl...@apache.org>
Date: 2016-03-31T13:15:25Z
Add property to accumulo-env.sh
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: Accumulo 4169 - context cleanup
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion closed the pull request at:
https://github.com/apache/accumulo/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: Accumulo 4169 - context cleanup
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on the pull request:
https://github.com/apache/accumulo/pull/85#issuecomment-204065062
Will commit locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: Accumulo 4169 - context cleanup
Posted by ivakegg <gi...@git.apache.org>.
Github user ivakegg commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/85#discussion_r58052698
--- Diff: start/src/main/java/org/apache/accumulo/start/classloader/vfs/ContextManager.java ---
@@ -189,13 +189,13 @@ public ClassLoader getClassLoader(String contextName) throws FileSystemException
}
}
- public void removeUnusedContexts(Set<String> inUse) {
+ public void removeUnusedContexts(Set<String> configuredContexts) {
--- End diff --
badly named.....we are not removing unused contexts here, we are removing from the list of unused contexts. Perhaps simply calling this removeConfiguredContexts or removeUsedContexts would make more sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---