You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/03/13 09:32:57 UTC
Review Request: Multiple ip address per nic changes for kvmhsot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9894/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthony xu.
Description
-------
Added MIPN chagnes for kvm host
This patch includes security groups rules chagnes
This addresses bug CLOUDSTACK-24.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 0a25bab
scripts/vm/network/security_group.py 83d7ad1
Diff: https://reviews.apache.org/r/9894/diff/
Testing
-------
1. Tested security group rules for nic secondary ip
2. VM reboot and tested security group rules adding and removing.
Thanks,
Jayapal Reddy
Re: Review Request: Multiple ip address per nic changes for kvmhsot
Posted by Abhinandan Prateek <ap...@apache.org>.
> On March 13, 2013, 5:33 p.m., anthony xu wrote:
> > Ship It!
For these changes kvm host installation process requires ipset to be installed. -- Jayapal.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9894/#review17809
-----------------------------------------------------------
On March 13, 2013, 8:32 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9894/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 8:32 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthony xu.
>
>
> Description
> -------
>
> Added MIPN chagnes for kvm host
> This patch includes security groups rules chagnes
>
>
> This addresses bug CLOUDSTACK-24.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 0a25bab
> scripts/vm/network/security_group.py 83d7ad1
>
> Diff: https://reviews.apache.org/r/9894/diff/
>
>
> Testing
> -------
>
> 1. Tested security group rules for nic secondary ip
> 2. VM reboot and tested security group rules adding and removing.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Multiple ip address per nic changes for kvmhsot
Posted by Jayapal Reddy <ja...@citrix.com>.
> On March 13, 2013, 5:33 p.m., anthony xu wrote:
> > Ship It!
>
> Abhinandan Prateek wrote:
> For these changes kvm host installation process requires ipset to be installed. -- Jayapal.
created a bug for the ipset installation as part of kvm agent installation
https://issues.apache.org/jira/browse/CLOUDSTACK-1689
- Jayapal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9894/#review17809
-----------------------------------------------------------
On March 13, 2013, 8:32 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9894/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 8:32 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthony xu.
>
>
> Description
> -------
>
> Added MIPN chagnes for kvm host
> This patch includes security groups rules chagnes
>
>
> This addresses bug CLOUDSTACK-24.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 0a25bab
> scripts/vm/network/security_group.py 83d7ad1
>
> Diff: https://reviews.apache.org/r/9894/diff/
>
>
> Testing
> -------
>
> 1. Tested security group rules for nic secondary ip
> 2. VM reboot and tested security group rules adding and removing.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Multiple ip address per nic changes for kvmhsot
Posted by anthony xu <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9894/#review17809
-----------------------------------------------------------
Ship it!
Ship It!
- anthony xu
On March 13, 2013, 8:32 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9894/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 8:32 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthony xu.
>
>
> Description
> -------
>
> Added MIPN chagnes for kvm host
> This patch includes security groups rules chagnes
>
>
> This addresses bug CLOUDSTACK-24.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 0a25bab
> scripts/vm/network/security_group.py 83d7ad1
>
> Diff: https://reviews.apache.org/r/9894/diff/
>
>
> Testing
> -------
>
> 1. Tested security group rules for nic secondary ip
> 2. VM reboot and tested security group rules adding and removing.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Multiple ip address per nic changes for kvmhsot
Posted by Abhinandan Prateek <ap...@apache.org>.
> On March 15, 2013, 1:21 a.m., Chip Childers wrote:
> > Anthony - Did you actually commit this?
committed.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9894/#review17938
-----------------------------------------------------------
On March 13, 2013, 8:32 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9894/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 8:32 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthony xu.
>
>
> Description
> -------
>
> Added MIPN chagnes for kvm host
> This patch includes security groups rules chagnes
>
>
> This addresses bug CLOUDSTACK-24.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 0a25bab
> scripts/vm/network/security_group.py 83d7ad1
>
> Diff: https://reviews.apache.org/r/9894/diff/
>
>
> Testing
> -------
>
> 1. Tested security group rules for nic secondary ip
> 2. VM reboot and tested security group rules adding and removing.
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Multiple ip address per nic changes for kvmhsot
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9894/#review17938
-----------------------------------------------------------
Anthony - Did you actually commit this?
- Chip Childers
On March 13, 2013, 8:32 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9894/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 8:32 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthony xu.
>
>
> Description
> -------
>
> Added MIPN chagnes for kvm host
> This patch includes security groups rules chagnes
>
>
> This addresses bug CLOUDSTACK-24.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 0a25bab
> scripts/vm/network/security_group.py 83d7ad1
>
> Diff: https://reviews.apache.org/r/9894/diff/
>
>
> Testing
> -------
>
> 1. Tested security group rules for nic secondary ip
> 2. VM reboot and tested security group rules adding and removing.
>
>
> Thanks,
>
> Jayapal Reddy
>
>