You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/20 07:30:18 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request #4404: [Doc] Add in predicate support content in delete-manual.md
caiconghui opened a new pull request #4404:
URL: https://github.com/apache/incubator-doris/pull/4404
## Proposed changes
Add in predicate support content in delete-manual.md
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [] I have create an issue on (Fix #4403 ), and have described the bug/feature there in detail
- [] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4404: [Doc] Add in predicate support content in delete-manual.md
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4404:
URL: https://github.com/apache/incubator-doris/pull/4404#discussion_r474054040
##########
File path: docs/en/administrator-guide/load-data/delete-manual.md
##########
@@ -162,6 +162,12 @@ In general, Doris's deletion timeout is limited from 30 seconds to 5 minutes. Th
* query_timeout
Because delete itself is an SQL command, the deletion statement is also limited by the session variables, and the timeout is also affected by the session value `query'timeout`. You can increase the value by `set query'timeout = xxx`.
+
+**InPredicate configuration**
+
+* max_allowed_in_element_num_of_delete
Review comment:
```suggestion
* `max_allowed_in_element_num_of_delete`
```
##########
File path: docs/zh-CN/administrator-guide/load-data/delete-manual.md
##########
@@ -158,6 +158,12 @@ Delete命令是一个SQL命令，返回结果是同步的，分为以下几种
因为delete本身是一个SQL命令，因此删除语句也会受session限制，timeout还受Session中的`query_timeout`值影响，可以通过`SET query_timeout = xxx`来增加超时时间，单位是秒。
+**IN谓词配置**
+
+* max_allowed_in_element_num_of_delete
Review comment:
```suggestion
* `max_allowed_in_element_num_of_delete`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4404: [Doc] Add in predicate support content in delete-manual.md
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4404:
URL: https://github.com/apache/incubator-doris/pull/4404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org